Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EPUB's cover.xhtml body should have id="cover" #1758

Closed
elmimmo opened this issue Nov 13, 2014 · 3 comments
Closed

EPUB's cover.xhtml body should have id="cover" #1758

elmimmo opened this issue Nov 13, 2014 · 3 comments

Comments

@elmimmo
Copy link

elmimmo commented Nov 13, 2014

The body element of the document cover.xhtml should have a unique attribute like id="cover" in order to be able to create a CSS style that targets it only.

One will most probably always want to reduce default page margins to zero for that document only, in order for ereaders to display that illustration from edge to edge of the screen (or at the very least as large as each ereader allows), or apply Adobe Digital Editions-only CSS oeb-column-number: 1 so that the cover is always displayed centered even when the ereader defaults to displaying facing pages.

Currently, the sole child of cover.xhtml's body element does have a distinctive attribute (<div id="cover-image">) but that does not help in being able to reduce its parent's default margins, which will pretty much always be non-zero.

@jgm jgm closed this as completed in 63443da Nov 17, 2014
jgm added a commit that referenced this issue Nov 17, 2014
This aids styling, making it possible for example to set 0 margins
on the title page.  Closes #1758.
@elmimmo
Copy link
Author

elmimmo commented Nov 17, 2014

My request was not about adding it to the title page (i.e. title_page.xhtml), but to the cover page (i.e. cover.xhtml), which is where the cover-image goes, and therefore where one would want pretty much always to reduce body margins to zero.

jgm pushed a commit that referenced this issue Nov 17, 2014
@jgm
Copy link
Owner

jgm commented Nov 17, 2014

Sorry! Better now?

+++ elmimmo [Nov 17 14 15:24 ]:

My request was not about adding it to the title page (i.e. title_page.xhtml), but to the cover page (i.e. cover.xhtml), which is where the cover-image goes, and therefore where one would want pretty much always to reduce body margins to zero.


Reply to this email directly or view it on GitHub:
#1758 (comment)

@elmimmo
Copy link
Author

elmimmo commented Nov 20, 2014

Looks good to me :-)

dschwilk pushed a commit to dschwilk/pandoc-templates that referenced this issue Apr 9, 2015
ivotron pushed a commit to ivotron/pandoc-templates that referenced this issue Jun 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants