Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Markdown image markup results in extra caption DIV in HTML output #28

Closed
tibbe opened this issue Jun 9, 2011 · 2 comments
Closed

Markdown image markup results in extra caption DIV in HTML output #28

tibbe opened this issue Jun 9, 2011 · 2 comments

Comments

@tibbe
Copy link

tibbe commented Jun 9, 2011

Converting the following Markdown snippet

![Foo](some-image.png)

to HTML results in an extra paragraph element containing "Foo" being inserted below the image. I would except the above to only cause the alt attribute to be set.
@jgm
Copy link
Owner

jgm commented Jun 9, 2011

See http://johnmacfarlane.net/pandoc/README.html#pictures-with-captions

+++ tibbe [Jun 09 11 01:55 ]:

Converting the following Markdown snippet

![Foo](some-image.png)

to HTML results in an extra paragraph element containing "Foo" being inserted below the image. I would except the above to only cause the alt attribute to be set.

@jgm
Copy link
Owner

jgm commented Jun 10, 2011

I'll close this issue. But feel free to comment if you think the "captioning" convention is confusing. Perhaps there's a better way.

@jgm jgm closed this as completed Jun 10, 2011
@jgm jgm mentioned this issue Feb 22, 2016
Closed
jgm pushed a commit that referenced this issue Feb 27, 2017
@yihui
Use \setkeys{Gin}{} to set appropriate defaults for \includegraphics,…
a3cce8d 
… instead of entirely redefining this command.

Note we also consider the height of images; if an image is too high, 0.8\textheight will be used for beamer slides, and \textheight is used for articles (see http://tex.stackexchange.com/q/11954/9128).

If the user has explicitly provided the width/height options in \includegraphics[], our defaults will be overwritten, and this approach is better than the check `\@ifnextchar[` after \includegraphics because the latter approach simply gives up everything once it sees [, whereas \setkeys{Gin} can keep the good defaults unless they are explicitly overwritten in [].

closes #30, closes #28, and closes #26
link2xt pushed a commit that referenced this issue Nov 5, 2017
@jgm
Merge pull request #28 from hubertp-lshift/feature/page-breaks
7e14aeb 
Adds PageBreak definitions
link2xt pushed a commit that referenced this issue Nov 5, 2017
@jgm
Revert "Merge pull request #28 from hubertp-lshift/feature/page-breaks"
cbae956 
This reverts commit 7e14aeb, reversing
changes made to e822163.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jgm @tibbe