Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Textile reader: bold and inline code interfere with each other #3024

Open
PowerKiKi opened this issue Jul 17, 2016 · 5 comments
Open

Textile reader: bold and inline code interfere with each other #3024

PowerKiKi opened this issue Jul 17, 2016 · 5 comments

Comments

@PowerKiKi
Copy link

It is not possible to read correctly a formatting made to look like GitHub mentions. The presence of @ and * interlaced breaks the output. This syntax should probably be supported as it is supported on https://txstyle.org/ and in Redmine.

Actual:

$ echo '*@John* not bold *@Jane*' | pandoc -f textile -t markdown
**`John* not bold *`Jane**

Expected:

$ echo '*@John* not bold *@Jane*' | pandoc -f textile -t markdown
**@John** not bold **@Jane**
@jgm
Copy link
Owner

jgm commented Jul 19, 2016

Pandoc's behavior matches that of the online dingus at https://txstyle.org/

@PowerKiKi
Copy link
Author

I beg to differ, the text "not bold" should not be bold. On https://txstyle.org/, entering the string

*@John* not bold *@Jane*

returns the correct HTML:

<p><strong>@John</strong> not bold <strong>@Jane</strong></p>

which corresponds to the expected output, but not actual output of pandoc. pandoc v1.17.2 will make the text "not bold" bold (and mess up the @ which disappear completely).

@jgm
Copy link
Owner

jgm commented Jul 19, 2016

OK, now I get this result too (I don't know why I thought I
got the other result last night).

It's not really clear to me what the rules are.
Nothing in the syntax description for inline code
rules out parsing @John* not bold *@ as an inline
code span.

+++ Adrien Crivelli [Jul 19 16 00:16 ]:

I beg to differ, the text "not bold" should not be bold. On
[1]https://txstyle.org/, entering the string
@john not bold @jane

returns the correct HTML:

@john not bold @jane

which corresponds to the expected output, but not actual output of
pandoc. pandoc v1.17.2 will make the text "not bold" bold (and mess up
the @ which disappear completely).


You are receiving this because you commented.
Reply to this email directly, [2]view it on GitHub, or [3]mute the
thread.

References

  1. https://txstyle.org/
  2. Textile reader: bold and inline code interfere with each other #3024 (comment)
  3. https://github.com/notifications/unsubscribe-auth/AAAL5BVZ7tOZKVSwCGigH2yl655s22xjks5qXHnYgaJpZM4JOKgk

@PowerKiKi
Copy link
Author

I didn't read the syntax, but wouldn't that be something along the lines of "an inline formatting cannot include another inline formatting" ? So the bold starts, the code is ignored, and then the bold finishes. Then one more time for the second word ?... That may be over simplistic though...

@jgm
Copy link
Owner

jgm commented Jul 19, 2016

You can have *_hi_*, emph in bold, so it's not that simple.

+++ Adrien Crivelli [Jul 19 16 09:28 ]:

I didn't read the syntax, but wouldn't that be something along the
lines of "an inline formatting cannot include another inline
formatting" ? So the bold starts, the code is ignored, and then the
bold finishes. Then one more time for the second word ?... That may be
over simplistic though...


You are receiving this because you commented.
Reply to this email directly, [1]view it on GitHub, or [2]mute the
thread.

References

  1. Textile reader: bold and inline code interfere with each other #3024 (comment)
  2. https://github.com/notifications/unsubscribe-auth/AAAL5BOT_qdvdhr63P8iI7WgV-WA3EoYks5qXPsigaJpZM4JOKgk

agusmba added a commit to agusmba/pandoc that referenced this issue Jan 11, 2019
agusmba added a commit to agusmba/pandoc that referenced this issue Jan 18, 2019
agusmba added a commit to agusmba/pandoc that referenced this issue Jan 24, 2019
agusmba added a commit to agusmba/pandoc that referenced this issue Jan 25, 2019
Solves the writer part of jgm#3024

Also supports additional core properties:
* subject
* lang
* category
* description

Includes golden tests
jgm pushed a commit that referenced this issue Jan 27, 2019
* docx writer: support custom properties.  Solves the writer part of #3024.
  Also supports additional core properties:  `subject`, `lang`, `category`,
  `description`.

* odt writer: improve standard properties, including the following core properties:
  `generator` (Pandoc/VERSION), `description`, `subject`, `keywords`,
  `initial-creator` (from authors), `creation-date` (actual creation date).
  Also fix date.

* pptx writer: support custom properties.  Also supports additional core
  properties: `subject`, `category`, `description`.

* Includes golden tests.

* MANUAL: document metadata support for docx, odt, pptx writers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants