Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hyperlinked image from markdown to rst is broken #611

Closed
salimane opened this issue Sep 15, 2012 · 3 comments
Closed

hyperlinked image from markdown to rst is broken #611

salimane opened this issue Sep 15, 2012 · 3 comments
Labels

Comments

@salimane
Copy link

markdown:

[![Build Status](https://secure.travis-ci.org/salimane/rediscluster-py.png?branch=master)](http://travis-ci.org/salimane/rediscluster-py)

actual rst ouput :

`|Build Status|`_

.. _|image1|: http://travis-ci.org/salimane/rediscluster-py

.. |Build
Status| image:: https://secure.travis-ci.org/salimane/rediscluster-py.png?branch=master
.. |image1| image:: https://secure.travis-ci.org/salimane/rediscluster-py.png?branch=master

expected rst result :

|Build Status|

.. |Build Status| image:: https://secure.travis-ci.org/salimane/rediscluster-py.png?branch=master
   :target: http://travis-ci.org/salimane/rediscluster-py
@jgm
Copy link
Owner

jgm commented Sep 16, 2012

Right. I didn't know about the :target: field; this may be new since I wrote the RST reader years ago. In any case, it should be supported in both the RST reader and the RST writer.

@jgm jgm closed this as completed in 23e1a25 Sep 16, 2012
@kennknowles
Copy link

Post-mortem comment.

I have this exact use case; a travis build icon in a github-flavored README.md that is converted to a PyPi-friendly README.txt at publish time. However, the current output does not seem to render properly on pypi.

Here is an example: https://pypi.python.org/pypi/commcare-export generated from https://github.com/dimagi/commcare-export/blob/master/README.md

I am going to investigate further by rendering with Python's docutils, but thought I would drop a note for posterity and/or those involved in this ticket.

@kennknowles
Copy link

Wrote too soon. The problem is a malformed table.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants