Change default background color of PDFs generated via HTML #8422
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating PDF output via HTML the background of
body
element istransparent
, so it uses the color ofhtml
which is set to#fdfdfd
by default. This may potentially lead to wasted printer ink. The introduced fix changes the default color for printing towhite
while respecting the case of user setting a custom background color.Steps to reproduce
Run
Before and after
The above pictures with increased contrast and lowered brightness