Writer.Docbook improvements: tight and loose lists, section levels #1250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Determined by the first block of the first item being Plain.
neilmayhew
changed the title
|
I had intended to make this two separate pull requests, but Github has merged them. Oh, well. |
Docbook can infer the section level from the nesting, and leaving out the level numbering allows Pandoc output to be inserted as a fragment into a larger Docbook document that already contains sections.
|
Just realized there's no need to limit depth any more, so pushed an amended commit. Hope this updates the pull request correctly. |
|
I cherry-picked your commit and made the change to use |
|
Please feel free to reopen the conversation about |
|
On 14-05-04 04:46 AM, John MacFarlane wrote:
Thanks, John. I'm away dealing with a family crisis at the moment, so |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Docbook output renders tight and loose lists identically. By default, Docbook lists are loose, but it provides an attribute
spacing="compact"to specify a tight list, on the list element itself. This commit adds the attribute when rendering tight lists. A list is considered to be tight if the first block of the first item is Plain.Docbook can number section levels explicitly, eg
<sect1>, or it can use the generic<section>element and let the nesting determine the level. The latter is preferable when Pandoc output needs to be inserted as a fragment into a larger Docbook document that already contains sections, because the fragment can then fit into any level in the section hierarchy.