Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fig, table-wrap & caption Divs for JATS writer #4148

Merged
merged 2 commits into from Dec 14, 2017
Merged

fig, table-wrap & caption Divs for JATS writer #4148

merged 2 commits into from Dec 14, 2017

Conversation

hamishmack
Copy link
Contributor

@hamishmack hamishmack commented Dec 12, 2017

Support writing <fig> and <table-wrap> elements with <title> and
<caption> inside them by using Divs with class set to on of
fig, table-wrap or cation. The title is included as a Heading
so the constraint on where Heading can occur is also relaxed.

Also leaves out empty alt attributes on links.

Support writing <fig> and <table-wrap> elements with <title> and
<caption> inside them by using Divs with class set to on of
fig, table-wrap or cation.  The title is included as a Heading
so the constraint on where Heading can occur is also relaxed.

Also leaves out empty alt attributes on links.
@hamishmack
Copy link
Contributor Author

This adds a bit of code duplication in blockToJATS with the version of the function that supports titles starting with fig. Do we still need that version or is it ok to only support using a Div? If we do I can refactor out the code duplication.

@jgm
Copy link
Owner

jgm commented Dec 13, 2017

Yes, we still need to support turning a Para containing just an image whose title starts with fig: into a figure. That's the standard (though hackish) way of representing a figure in pandoc.

@jgm jgm merged commit 3361f85 into jgm:master Dec 14, 2017
@jgm
Copy link
Owner

jgm commented Dec 14, 2017

Great, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants