Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default.context #5875

Merged
merged 3 commits into from Nov 17, 2019
Merged

Update default.context #5875

merged 3 commits into from Nov 17, 2019

Conversation

denismaier
Copy link
Contributor

Define an start-stop-pair cslreferences to allow for hanging indents in the bibliography. Analogous to the cslreferences-environment in the default latex template. See here: jgm/pandoc-citeproc#410
For this to work the context writer must be adapted.

Define an start-stop-pair `cslreferences` to allow for hanging indents in the bibliography. Analogous to the cslreferences-environment in the default latex template. See here: jgm/pandoc-citeproc#410
For this to work the context writer must be adapted.
@denismaier
Copy link
Contributor Author

Sorry, I don't understand what is going wrong here. Any hints?

@jgm
Copy link
Owner

jgm commented Nov 5, 2019

Look at the test failures. Here's one (I didn't look to see if there were others):

          ------------------------------------------------------------------------
1340
          --- writer.context
1341
          +++ /home/runner/work/pandoc/pandoc/dist-newstyle/build/x86_64-linux/ghc-8.4.4/pandoc-2.8/x/pandoc/noopt/build/pandoc/pandoc --data-dir=../data --quiet testsuite.native -r native -w context --columns=78 --variable pandoc-version= -s
1342
          +  60 % Wrap CSL references in start-stop-environment
1343
          +  62 
1344
          ------------------------------------------------------------------------
1345

This is showing that the result of running the context writer test doesn't match the expected output (test/writer.context): it contains these additional two lines.

If you intended your change not to have any effect unless a variable is set a certain way, it didn't have this effect. Maybe you need to move more things under the conditional?

@denismaier
Copy link
Contributor Author

denismaier commented Nov 5, 2019

Well, but that's only a comment and an additional empty line, both only there for more readable code. Should I remove those?

@jgm
Copy link
Owner

jgm commented Nov 5, 2019

It makes sense to put them under the conditional. Otherwise they appear in all context documents, even when pandoc-citeproc isn't used. The comment will certainly seem odd without the stuff following it. Alternatively, you can use the syntax $-- to create a template comment which won't appear in the fgenerated source.

@jgm jgm merged commit c4e198c into jgm:master Nov 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants