Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add lua path manipulation functions #6565

Closed
wants to merge 4 commits into from
Closed

Add lua path manipulation functions #6565

wants to merge 4 commits into from

Conversation

gabyx
Copy link

@gabyx gabyx commented Jul 26, 2020 •
edited

Corresponding PR for https://github.com/hslua/hslua-module-system/pull/1/files
Once the mentioned is merged, hopefully this PR passes the tests (I am newbie with haskell, please help).

@gabyx gabyx changed the title Add path manipulation functions Add lua path manipulation functions Jul 26, 2020
@gabyx gabyx mentioned this pull request Jul 26, 2020
Closed
@gabyx gabyx force-pushed the feature/add-lua-path-manipulations branch from 40e9ee8 to d8e5f5e Compare July 26, 2020 20:05
@gabyx
Copy link
Author

gabyx commented Jul 27, 2020

@tarleb: Are you able to also quickly review, this? I tested it yesterday, with stack and some custom git repo dependency. It worked.
I think it needs forwarding documentation to the hslua-system module stil...

@tarleb
Copy link
Collaborator

tarleb commented Jul 27, 2020

I need to do a new hslua-module-system release first, and I'd like to solve #6001 while we are at it. And the final decision, as with anything affecting the API, is with @jgm.

This was referenced Jul 27, 2020
Closed
Closed
tarleb added a commit to tarleb/pandoc that referenced this pull request Feb 1, 2021
@tarleb
Lua: add module "pandoc.path"
d6eebd8 
The module allows to work with file paths in a convenient and
platform-independent manner.

Closes: jgm#6001
Closes: jgm#6565
tarleb added a commit to tarleb/pandoc that referenced this pull request Feb 1, 2021
@tarleb
Lua: add module "pandoc.path"
922744b 
The module allows to work with file paths in a convenient and
platform-independent manner.

Closes: jgm#6001
Closes: jgm#6565
tarleb added a commit to tarleb/pandoc that referenced this pull request Feb 1, 2021
@tarleb
Lua: add module "pandoc.path"
733df89 
The module allows to work with file paths in a convenient and
platform-independent manner.

Closes: jgm#6001
Closes: jgm#6565
@jgm jgm closed this in 61b108d Feb 3, 2021
@gabyx
Copy link
Author

gabyx commented Feb 3, 2021

Thanks a lot! @tarleb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gabyx @tarleb