Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DocBook reader: Support informalfigure #7079

Merged
merged 1 commit into from
Feb 8, 2021
Merged

DocBook reader: Support informalfigure #7079

merged 1 commit into from
Feb 8, 2021

Conversation

pyssling
Copy link
Contributor

@pyssling pyssling commented Feb 5, 2021

Add support for informalfigure.

@jgm
Copy link
Owner

jgm commented Feb 7, 2021

What about using getFigure here instead of getBlocks?
If the element doesn't contain a title, then it will do much the same thing (except that it will also have the id information available). And when we add a Figure element in the future, we'll presumably want both of these things to produce one.

Add support for informalfigure.
@pyssling
Copy link
Contributor Author

pyssling commented Feb 7, 2021

done.

@jgm jgm merged commit 69b7401 into jgm:master Feb 8, 2021
@jgm
Copy link
Owner

jgm commented Feb 8, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants