Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disable vertical content centering #7105

Merged
merged 2 commits into from
Feb 20, 2021

Conversation

maurerle
Copy link
Contributor

fixes #7104

@@ -82,6 +82,10 @@ $endif$
// Full list of configuration options available at:
// https://revealjs.com/config/
Reveal.initialize({
$if(center)$
// Determines wether slide content should be vertically centered
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wether -> whether

@jgm jgm merged commit 6b7d614 into jgm:master Feb 20, 2021
@jgm
Copy link
Owner

jgm commented Feb 20, 2021

thanks!

@maurerle maurerle deleted the maurerle-content-center branch February 20, 2021 18:54
@maurerle
Copy link
Contributor Author

This is flawed as center defaults to true and setting it to false does not trigger the if(center), therefore changes nothing.

This should check if center is defined.

@jgm
Copy link
Owner

jgm commented Jun 19, 2021

You're right -- please open a new issue for this so we can track it.
Note that the template language doesn't allow you to check definedness or distinguish between false and undefined. We may need some special support for setting this variable in the writer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RevealJS vertical center option not working
2 participants