Docx reader: add handling of vml image objects (jgm#4735) #7257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They represent images, the same way as other images in vml format.
jgm
reviewed
Apr 29, 2021
Comment on lines
+723
to
+729
| elemToParPart ns element | ||
| | isElem ns "w" "r" element | ||
| , Just objectElem <- findChildByName ns "w" "object" element | ||
| , Just shapeElem <- findChildByName ns "v" "shape" objectElem | ||
| , Just imagedataElem <- findChildByName ns "v" "imagedata" shapeElem | ||
| , Just drawingId <- findAttrByName ns "r" "id" imagedataElem | ||
| = expandDrawingId drawingId >>= (\(fp, bs) -> return $ Drawing fp "" "" bs Nothing) |
There was a problem hiding this comment.
Big improvement in code clarity!
(EDIT: what I mean is that we should rewrite the stanza above in the same style.)
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As explained on the mailing list as well:
Currently, when parsing a docx, a v:imagedata tag inside a w:r/w:object/v:shape
is ignored. But it could be treated the same as a v:imagedata inside a
w:r/w:pict, both represent images linked by the r:id attribute.
In fact, we now use a pre-processing to transform a
w:r/w:object/v:shape/v:imagedata to a w:r/w:pict/v:imagedata before transforming
with Pandoc and we have tested this on many documents.