Lua: extract marshaling code to pandoc-lua-marshal package #7719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 26, 2021
tarleb
force-pushed
the
hslua-pandoc-types
branch
2 times, most recently
from
ecfc29f
to
0ba6a76
Compare
The marshaling functions for pandoc's AST are extracted into a separate
package. The package comes with a number of changes:
- Pandoc's List module was rewritten in C, thereby improving error
messages.
- Lists of `Block` and `Inline` elements are marshaled using the new
list types `Blocks` and `Inlines`, respectively. These types
currently behave identical to the generic List type, but give better
error messages. This also opens up the possibility of adding
element-specific methods to these lists in the future.
- Elements of type `MetaValue` are no longer pushed as values which
have `.t` and `.tag` properties. This was already true for
`MetaString` and `MetaBool` values, which are still marshaled as Lua
strings and booleans, respectively. Affected values:
+ `MetaBlocks` values are marshaled as a `Blocks` list;
+ `MetaInlines` values are marshaled as a `Inlines` list;
+ `MetaList` values are marshaled as a generic pandoc `List`s.
+ `MetaMap` values are marshaled as plain tables and no longer
given any metatable.
- The test suite for marshaled objects and their constructors has
been extended and improved.
- A bug in Citation objects, where setting a citation's suffix
modified it's prefix, has been fixed.
tarleb
force-pushed
the
hslua-pandoc-types
branch
from
0ba6a76
to
d7d8fbb
Compare
tarleb
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The marshaling functions for pandoc's AST are extracted into a separate
package. The switch comes with a number of changes:
Pandoc's List module was rewritten in C, thereby improving error
messages.
Data files
pandoc.luaandpandoc.List.luahave been removed.Lists of
BlockandInlineelements are marshaled using the newlist types
BlocksandInlines, respectively. These typescurrently behave identical to the generic List type, but give better
error messages. This also opens up the possibility of adding
element-specific methods to these lists in the future.
Elements of type
MetaValueare no longer pushed as values whichhave
.tand.tagproperties. This was already true forMetaStringandMetaBoolvalues, which are still marshaled as Luastrings and booleans, respectively. Affected values:
MetaBlocksvalues are marshaled as aBlockslist;MetaInlinesvalues are marshaled as aInlineslist;MetaListvalues are marshaled as a generic pandocLists.MetaMapvalues are marshaled as plain tables and no longergiven any metatable.
The test suite for marshaled objects and their constructors has
been extended and improved.
A bug in Citation objects, where setting a citation's suffix
modified it's prefix, has been fixed.