#8979 Support attr text:continue-numbering on ODT Reader
#8998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgm
reviewed
Aug 14, 2023
|
@jgm I refactored the code to make the functionality more clear. |
StephanMeijer
changed the title
text:continue-numbering on ODT Reader
StephanMeijer
force-pushed
the
feature/8979-continue-numbering
branch
from
47f1915
to
e9bf624
Compare
|
@jgm Updated PR with cleaner example for test. Would you be willing to review once again? 🙏 |
jgm
reviewed
Aug 18, 2023
jgm
reviewed
Aug 18, 2023
jgm
requested changes
Aug 18, 2023
|
@jgm Feedback taken into account and changed things appropriately. I didn't test locally so I will test on CI/CD. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please keep the following in mind: I am a beginner in Haskell. So in case I wrote garbage, please don't judge me too harshly. Please also check thoroughly before merging. Thanks!
See #8979
.odtto be from LibreOffice not Google Docs, so.native-output isn't cluttered withBlockQuote.