Fixing wrong numbered-list indentation in open document format #910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't understand all of the details of this module (written by Andrea Rossato), but your changes look good to me and the results look good in my tests. Many thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #369
The problem seems to stem from the fact that LibreOffice doesn't like the combination of numbered lists and anything to do with
fo:margin-leftfo:margin-rightor indentation styles.Looking at the code it seems these indentation specific attributes are triggered in
style:paragraph-propertieseven in the "tight" style case, even though they seem to be independent. I have tested this with the test case and a few other simple documents, but I am unsure if I have overlooked anything.