Updates for calibre 6/Qt6 #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some users, calibre 6/Qt6 is not handling the Qt4 compatibility code.
Issues came up earlier in the year with errors that were related to thread safety. These were fixed beta but not checked in. They have come up again for calibre 6.
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With calibre 6/Qt6, a problem with Qt4 backward compatibility code has been reported by some users on Windows. This is not needed as the plugins do not support calibre versions using Qt4.
Another issue came up with thread safety. This happened earlier in the year for a few users and the code was developed and tested at the time. It has been reported again with calibre 6. The changes have been discussed and tested in the Kepub Output plugin thread on MR.