Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Otel first steps #74

Merged
merged 36 commits into from
Nov 25, 2023
Merged

Otel first steps #74

merged 36 commits into from
Nov 25, 2023

Conversation

jgomezselles
Copy link
Owner

@jgomezselles jgomezselles commented Sep 22, 2023 •
edited

This PR adds OpenTelemetry metrics support and brings a victoria backend with a grafana

ToDos:

  • Add OTel libs into Dockerfile base
  • Add libs into the code
  • Add grafana and metrics backend
  • Adapt unit tests
  • Configure hermes svc endpoint
  • Tie svc endpoint from helm
  • Check versions and publish dockerfiles
  • Check CI

Out of scope: OTel collector and other backends

@jgomezselles jgomezselles added documentation Improvements or additions to documentation enhancement New feature or request Env & tools Testing labels Sep 22, 2023
@jgomezselles jgomezselles added this to the Add a server to hermes milestone Sep 22, 2023
@coveralls
Copy link

coveralls commented Nov 12, 2023 •
edited

Pull Request Test Coverage Report for Build 6989456074

  • 140 of 141 (99.29%) changed or added relevant lines in 8 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 96.907%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/o11y/tracer.cpp 38 39 97.44%
Totals Coverage Status
Change from base Build 5742253014: 0.4%
Covered Lines: 940
Relevant Lines: 970
💛 - Coveralls

@jgomezselles jgomezselles self-assigned this Nov 25, 2023
@jgomezselles jgomezselles linked an issue Nov 25, 2023 that may be closed by this pull request
Add prometheus metrics #37
Closed
@jgomezselles jgomezselles marked this pull request as ready for review November 25, 2023 13:50
@jgomezselles jgomezselles merged commit ce44f11 into main Nov 25, 2023
6 checks passed
@jgomezselles jgomezselles deleted the otel-first-steps branch November 25, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jgomezselles jgomezselles

Labels
documentation Improvements or additions to documentation enhancement New feature or request Env & tools Testing
Projects
None yet
Milestone
Add a server to hermes
Development

Successfully merging this pull request may close these issues.

Add prometheus metrics
2 participants
@jgomezselles @coveralls