Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement --freeze-outdated-packages argument #98

Merged
merged 2 commits into from
Nov 29, 2022
Merged

Implement --freeze-outdated-packages argument #98

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c9ede25
implement --freeze-outdated-packages argument
hueseyincelik Nov 26, 2022
f26dacb
remove -f short argument
hueseyincelik Nov 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
15 changes: 12 additions & 3 deletions pip_review/__main__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,9 @@ def parse_args():
parser.add_argument(
'--continue-on-fail', '-C', action='store_true', default=False,
help='Continue with other installs when one fails')
parser.add_argument(
'--freeze-outdated-packages', '-f', action='store_true', default=False,
jgonggrijp marked this conversation as resolved.
Show resolved Hide resolved
help='Freeze all outdated packages to "requirements.txt" before upgrading them')
return parser.parse_known_args()


Expand Down Expand Up @@ -166,8 +169,14 @@ def ask(self, prompt):
ask_to_install = partial(InteractiveAsker().ask, prompt='Upgrade now?')


def update_packages(packages, forwarded, continue_on_fail):
def update_packages(packages, forwarded, continue_on_fail, freeze_outdated_packages):
upgrade_cmd = pip_cmd() + ['install', '-U'] + forwarded

if freeze_outdated_packages:
with open('requirements.txt', 'w') as f:
for pkg in packages:
f.write('{0}=={1}\n'.format(pkg['name'], pkg['version']))

if not continue_on_fail:
upgrade_cmd += ['{0}'.format(pkg['name']) for pkg in packages]
subprocess.call(upgrade_cmd, stdout=sys.stdout, stderr=sys.stderr)
Expand Down Expand Up @@ -232,7 +241,7 @@ def main():
if not outdated and not args.raw:
logger.info('Everything up-to-date')
elif args.auto:
update_packages(outdated, install_args, args.continue_on_fail)
update_packages(outdated, install_args, args.continue_on_fail, args.freeze_outdated_packages)
elif args.raw:
for pkg in outdated:
logger.info('{0}=={1}'.format(pkg['name'], pkg['latest_version']))
Expand All @@ -247,7 +256,7 @@ def main():
if answer in ['y', 'a']:
selected.append(pkg)
if selected:
update_packages(selected, install_args, args.continue_on_fail)
update_packages(selected, install_args, args.continue_on_fail, args.freeze_outdated_packages)


if __name__ == '__main__':
Expand Down