Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Django 1.10 support #54

Merged
merged 7 commits into from Aug 18, 2016
Merged

Added Django 1.10 support #54

merged 7 commits into from Aug 18, 2016

Conversation

pawelad
Copy link
Contributor

@pawelad pawelad commented Aug 17, 2016

As discussed in #53, NoArgsCommand is deprecated in Django 1.10 which makes django-kronos unusable. Fortunately the fix is easy (via docs):

class NoArgsCommand
    Deprecated since version 1.8:
    Use BaseCommand instead, which takes no arguments by default.

I also added Django 1.10 and Python 3.5 to testing config (both tox.ini and travis.yml).

@coveralls
Copy link

coveralls commented Aug 17, 2016

Coverage Status

Coverage remained the same at 87.597% when pulling 7142961 on pawelad:master into 9687aed on jgorset:master.

1 similar comment
@coveralls
Copy link

coveralls commented Aug 17, 2016

Coverage Status

Coverage remained the same at 87.597% when pulling 7142961 on pawelad:master into 9687aed on jgorset:master.

@pawelad
Copy link
Contributor Author

pawelad commented Aug 17, 2016

Hm - the problem with NoArgsCommand seems to be fixed, but Django 1.10 builds fail with django.core.management.base.CommandError: Error: unrecognized arguments: complain.

I'm looking into it.

@coveralls
Copy link

coveralls commented Aug 17, 2016

Coverage Status

Coverage increased (+0.1%) to 87.739% when pulling 9d1b4ed on pawelad:master into 9687aed on jgorset:master.

@coveralls
Copy link

coveralls commented Aug 17, 2016

Coverage Status

Coverage increased (+0.1%) to 87.692% when pulling cee2d94 on pawelad:master into 9687aed on jgorset:master.

@pawelad
Copy link
Contributor Author

pawelad commented Aug 17, 2016

Third time's the charm ; -)

Though the only way I managed to get it working on 1.10 was to drop support for 1.7. It's not supported anymore so that shouldn't be a big problem (or at least I hope it isn't), but probably warrants a new release.

@coveralls
Copy link

coveralls commented Aug 17, 2016

Coverage Status

Coverage increased (+0.1%) to 87.692% when pulling 2425614 on pawelad:master into 9687aed on jgorset:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 87.692% when pulling 2425614 on pawelad:master into 9687aed on jgorset:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 87.692% when pulling 2425614 on pawelad:master into 9687aed on jgorset:master.

@jgorset
Copy link
Owner

jgorset commented Aug 18, 2016

Thanks @pawelad! I think dropping support for 1.7 is fine, too. Have 🍰!

@jgorset jgorset merged commit 392dbd6 into jgorset:master Aug 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants