[Cross Cluster Replication] NP Shim (elastic#60121) (elastic#60635)

* Public in WiP state, removed all 'ui/' imports

* First iteration of public shimmed and working

* A whole lotta WIP server side

* Server-side to using the NP router + client side changes

Updated the client code to properly encode requests to the
server. Did first E2E test.

Route tests are probably broken, need to fix them.

* Removed unused error wrapping code

* Update client Jest tests

* Add breadcrumbs service mock

* Fix server side Jest tests

* Add helper functions file for server side Jest tests

* Fix API integration tests

* Fixed boolean logic mistake in due to refactor in index mgmt ext.

Also migrated to the a more NP friendly version of index mgmt
extension.

* Remove unused import

* Clean up some cruft and refactor URL variable names

* Fix stringification of body and fix boolean server logic

* Fix mocha

Folder called __tests__ with Jest tests was breaking mocha.

* Refactor to Jest test

* Fix types issues in jest test

* Migrate to new config-schema API

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

x-pack/legacy/plugins/cross_cluster_replication/__jest__/client_integration/auto_follow_pattern_add.test.js

@@ -3,7 +3,7 @@
  * or more contributor license agreements. Licensed under the Elastic License;
  * you may not use this file except in compliance with the Elastic License.
  */
-
+import '../../public/np_ready/app/services/breadcrumbs.mock';
 import { setupEnvironment, pageHelpers, nextTick, getRandomString } from './helpers';
 import { indexPatterns } from '../../../../../../src/plugins/data/public';
 

x-pack/legacy/plugins/cross_cluster_replication/__jest__/client_integration/auto_follow_pattern_edit.test.js

@@ -4,7 +4,8 @@
  * you may not use this file except in compliance with the Elastic License.
  */
 
-import { AutoFollowPatternForm } from '../../public/app/components/auto_follow_pattern_form';
+import '../../public/np_ready/app/services/breadcrumbs.mock';
+import { AutoFollowPatternForm } from '../../public/np_ready/app/components/auto_follow_pattern_form';
 import { setupEnvironment, pageHelpers, nextTick } from './helpers';
 import { AUTO_FOLLOW_PATTERN_EDIT } from './helpers/constants';
 

x-pack/legacy/plugins/cross_cluster_replication/__jest__/client_integration/auto_follow_pattern_list.test.js

@@ -4,21 +4,13 @@
  * you may not use this file except in compliance with the Elastic License.
  */
 
+import '../../public/np_ready/app/services/breadcrumbs.mock';
 import { setupEnvironment, pageHelpers, nextTick, getRandomString } from './helpers';
 
 import { getAutoFollowPatternClientMock } from '../../fixtures/auto_follow_pattern';
 
 jest.mock('ui/new_platform');
 
-jest.mock('ui/chrome', () => ({
-  addBasePath: () => 'api/cross_cluster_replication',
-  breadcrumbs: { set: () => {} },
-  getUiSettingsClient: () => ({
-    get: x => x,
-    getUpdate$: () => ({ subscribe: jest.fn() }),
-  }),
-}));
-
 const { setup } = pageHelpers.autoFollowPatternList;
 
 describe('<AutoFollowPatternList />', () => {

x-pack/legacy/plugins/cross_cluster_replication/__jest__/client_integration/follower_index_add.test.js

@@ -4,8 +4,9 @@
  * you may not use this file except in compliance with the Elastic License.
  */
 
+import '../../public/np_ready/app/services/breadcrumbs.mock';
 import { setupEnvironment, pageHelpers, nextTick } from './helpers';
-import { RemoteClustersFormField } from '../../public/app/components';
+import { RemoteClustersFormField } from '../../public/np_ready/app/components';
 
 import { indexPatterns } from '../../../../../../src/plugins/data/public';
 

x-pack/legacy/plugins/cross_cluster_replication/__jest__/client_integration/follower_index_edit.test.js

@@ -4,8 +4,9 @@
  * you may not use this file except in compliance with the Elastic License.
  */
 
+import '../../public/np_ready/app/services/breadcrumbs.mock';
 import { setupEnvironment, pageHelpers, nextTick } from './helpers';
-import { FollowerIndexForm } from '../../public/app/components/follower_index_form/follower_index_form';
+import { FollowerIndexForm } from '../../public/np_ready/app/components/follower_index_form/follower_index_form';
 import { FOLLOWER_INDEX_EDIT } from './helpers/constants';
 
 jest.mock('ui/new_platform');

x-pack/legacy/plugins/cross_cluster_replication/__jest__/client_integration/follower_indices_list.test.js

@@ -10,15 +10,6 @@ import { getFollowerIndexMock } from '../../fixtures/follower_index';
 
 jest.mock('ui/new_platform');
 
-jest.mock('ui/chrome', () => ({
-  addBasePath: () => 'api/cross_cluster_replication',
-  breadcrumbs: { set: () => {} },
-  getUiSettingsClient: () => ({
-    get: x => x,
-    getUpdate$: () => ({ subscribe: jest.fn() }),
-  }),
-}));
-
 const { setup } = pageHelpers.followerIndexList;
 
 describe('<FollowerIndicesList />', () => {

x-pack/legacy/plugins/cross_cluster_replication/__jest__/client_integration/helpers/auto_follow_pattern_add.helpers.js

@@ -5,9 +5,9 @@
  */
 
 import { registerTestBed } from '../../../../../../test_utils';
-import { AutoFollowPatternAdd } from '../../../public/app/sections/auto_follow_pattern_add';
-import { ccrStore } from '../../../public/app/store';
-import routing from '../../../public/app/services/routing';
+import { AutoFollowPatternAdd } from '../../../public/np_ready/app/sections/auto_follow_pattern_add';
+import { ccrStore } from '../../../public/np_ready/app/store';
+import routing from '../../../public/np_ready/app/services/routing';
 
 const testBedConfig = {
   store: ccrStore,

x-pack/legacy/plugins/cross_cluster_replication/__jest__/client_integration/helpers/auto_follow_pattern_edit.helpers.js

@@ -5,9 +5,9 @@
  */
 
 import { registerTestBed } from '../../../../../../test_utils';
-import { AutoFollowPatternEdit } from '../../../public/app/sections/auto_follow_pattern_edit';
-import { ccrStore } from '../../../public/app/store';
-import routing from '../../../public/app/services/routing';
+import { AutoFollowPatternEdit } from '../../../public/np_ready/app/sections/auto_follow_pattern_edit';
+import { ccrStore } from '../../../public/np_ready/app/store';
+import routing from '../../../public/np_ready/app/services/routing';
 
 import { AUTO_FOLLOW_PATTERN_EDIT_NAME } from './constants';
 

x-pack/legacy/plugins/cross_cluster_replication/__jest__/client_integration/helpers/auto_follow_pattern_list.helpers.js

@@ -5,9 +5,9 @@
  */
 
 import { registerTestBed, findTestSubject } from '../../../../../../test_utils';
-import { AutoFollowPatternList } from '../../../public/app/sections/home/auto_follow_pattern_list';
-import { ccrStore } from '../../../public/app/store';
-import routing from '../../../public/app/services/routing';
+import { AutoFollowPatternList } from '../../../public/np_ready/app/sections/home/auto_follow_pattern_list';
+import { ccrStore } from '../../../public/np_ready/app/store';
+import routing from '../../../public/np_ready/app/services/routing';
 
 const testBedConfig = {
   store: ccrStore,

x-pack/legacy/plugins/cross_cluster_replication/__jest__/client_integration/helpers/follower_index_add.helpers.js

@@ -5,9 +5,9 @@
  */
 
 import { registerTestBed } from '../../../../../../test_utils';
-import { FollowerIndexAdd } from '../../../public/app/sections/follower_index_add';
-import { ccrStore } from '../../../public/app/store';
-import routing from '../../../public/app/services/routing';
+import { FollowerIndexAdd } from '../../../public/np_ready/app/sections/follower_index_add';
+import { ccrStore } from '../../../public/np_ready/app/store';
+import routing from '../../../public/np_ready/app/services/routing';
 
 const testBedConfig = {
   store: ccrStore,

x-pack/legacy/plugins/cross_cluster_replication/__jest__/client_integration/helpers/follower_index_edit.helpers.js

@@ -5,9 +5,9 @@
  */
 
 import { registerTestBed } from '../../../../../../test_utils';
-import { FollowerIndexEdit } from '../../../public/app/sections/follower_index_edit';
-import { ccrStore } from '../../../public/app/store';
-import routing from '../../../public/app/services/routing';
+import { FollowerIndexEdit } from '../../../public/np_ready/app/sections/follower_index_edit';
+import { ccrStore } from '../../../public/np_ready/app/store';
+import routing from '../../../public/np_ready/app/services/routing';
 
 import { FOLLOWER_INDEX_EDIT_NAME } from './constants';
 

x-pack/legacy/plugins/cross_cluster_replication/__jest__/client_integration/helpers/follower_index_list.helpers.js

@@ -5,9 +5,9 @@
  */
 
 import { registerTestBed, findTestSubject } from '../../../../../../test_utils';
-import { FollowerIndicesList } from '../../../public/app/sections/home/follower_indices_list';
-import { ccrStore } from '../../../public/app/store';
-import routing from '../../../public/app/services/routing';
+import { FollowerIndicesList } from '../../../public/np_ready/app/sections/home/follower_indices_list';
+import { ccrStore } from '../../../public/np_ready/app/store';
+import routing from '../../../public/np_ready/app/services/routing';
 
 const testBedConfig = {
   store: ccrStore,

x-pack/legacy/plugins/cross_cluster_replication/__jest__/client_integration/helpers/home.helpers.js

@@ -5,9 +5,9 @@
  */
 
 import { registerTestBed } from '../../../../../../test_utils';
-import { CrossClusterReplicationHome } from '../../../public/app/sections/home/home';
-import { ccrStore } from '../../../public/app/store';
-import routing from '../../../public/app/services/routing';
+import { CrossClusterReplicationHome } from '../../../public/np_ready/app/sections/home/home';
+import { ccrStore } from '../../../public/np_ready/app/store';
+import routing from '../../../public/np_ready/app/services/routing';
 import { BASE_PATH } from '../../../common/constants';
 
 const testBedConfig = {

x-pack/legacy/plugins/cross_cluster_replication/__jest__/client_integration/helpers/http_requests.js

@@ -19,7 +19,7 @@ const registerHttpRequestMockHelpers = server => {
 
     server.respondWith(
       'GET',
-      'api/cross_cluster_replication/follower_indices',
+      '/api/cross_cluster_replication/follower_indices',
       mockResponse(defaultResponse, response)
     );
   };
@@ -29,7 +29,7 @@ const registerHttpRequestMockHelpers = server => {
 
     server.respondWith(
       'GET',
-      'api/cross_cluster_replication/auto_follow_patterns',
+      '/api/cross_cluster_replication/auto_follow_patterns',
       mockResponse(defaultResponse, response)
     );
   };
@@ -39,7 +39,7 @@ const registerHttpRequestMockHelpers = server => {
 
     server.respondWith(
       'DELETE',
-      /api\/cross_cluster_replication\/auto_follow_patterns/,
+      /\/api\/cross_cluster_replication\/auto_follow_patterns/,
       mockResponse(defaultResponse, response)
     );
   };
@@ -61,7 +61,7 @@ const registerHttpRequestMockHelpers = server => {
 
     server.respondWith(
       'GET',
-      'api/cross_cluster_replication/stats/auto_follow',
+      '/api/cross_cluster_replication/stats/auto_follow',
       mockResponse(defaultResponse, response)
     );
   };
@@ -87,7 +87,7 @@ const registerHttpRequestMockHelpers = server => {
 
     server.respondWith(
       'GET',
-      /api\/cross_cluster_replication\/auto_follow_patterns\/.+/,
+      /\/api\/cross_cluster_replication\/auto_follow_patterns\/.+/,
       mockResponse(defaultResponse, response)
     );
   };
@@ -105,7 +105,7 @@ const registerHttpRequestMockHelpers = server => {
 
     server.respondWith(
       'GET',
-      /api\/cross_cluster_replication\/follower_indices\/.+/,
+      /\/api\/cross_cluster_replication\/follower_indices\/.+/,
       mockResponse(defaultResponse, response)
     );
   };

x-pack/legacy/plugins/cross_cluster_replication/__jest__/client_integration/helpers/setup_environment.js

@@ -7,14 +7,15 @@
 import axios from 'axios';
 import axiosXhrAdapter from 'axios/lib/adapters/xhr';
 
-import { setHttpClient } from '../../../public/app/services/api';
+import { setHttpClient } from '../../../public/np_ready/app/services/api';
 import { init as initHttpRequests } from './http_requests';
 
 export const setupEnvironment = () => {
-  // Mock Angular $q
-  const $q = { defer: () => ({ resolve() {} }) };
-  // axios has a $http like interface so using it to simulate $http
-  setHttpClient(axios.create({ adapter: axiosXhrAdapter }), $q);
+  // axios has a similar interface to HttpSetup, but we
+  // flatten out the response.
+  const client = axios.create({ adapter: axiosXhrAdapter });
+  client.interceptors.response.use(({ data }) => data);
+  setHttpClient(client);
 
   const { server, httpRequestsMockHelpers } = initHttpRequests();
 

x-pack/legacy/plugins/cross_cluster_replication/__jest__/client_integration/home.test.js

@@ -4,6 +4,7 @@
  * you may not use this file except in compliance with the Elastic License.
  */
 
+import '../../public/np_ready/app/services/breadcrumbs.mock';
 import { setupEnvironment, pageHelpers, nextTick } from './helpers';
 
 jest.mock('ui/new_platform');

x-pack/legacy/plugins/cross_cluster_replication/index.js

@@ -6,9 +6,7 @@
 
 import { resolve } from 'path';
 import { PLUGIN } from './common/constants';
-import { registerLicenseChecker } from './server/lib/register_license_checker';
-import { registerRoutes } from './server/routes/register_routes';
-import { ccrDataEnricher } from './cross_cluster_replication_data';
+import { plugin } from './server/np_ready';
 
 export function crossClusterReplication(kibana) {
   return new kibana.Plugin({
@@ -47,15 +45,13 @@ export function crossClusterReplication(kibana) {
       );
     },
     init: function initCcrPlugin(server) {
-      registerLicenseChecker(server);
-      registerRoutes(server);
-      if (
-        server.config().get('xpack.ccr.ui.enabled') &&
-        server.newPlatform.setup.plugins.indexManagement &&
-        server.newPlatform.setup.plugins.indexManagement.indexDataEnricher
-      ) {
-        server.newPlatform.setup.plugins.indexManagement.indexDataEnricher.add(ccrDataEnricher);
-      }
+      plugin({}).setup(server.newPlatform.setup.core, {
+        indexManagement: server.newPlatform.setup.plugins.indexManagement,
+        __LEGACY: {
+          server,
+          ccrUIEnabled: server.config().get('xpack.ccr.ui.enabled'),
+        },
+      });
     },
   });
 }

x-pack/legacy/plugins/cross_cluster_replication/public/index.js

@@ -5,4 +5,3 @@
  */
 
 import './register_routes';
-import './extend_index_management';

x-pack/legacy/plugins/cross_cluster_replication/public/index.scss

@@ -10,4 +10,4 @@
 //   ccrChart__legend--small
 //   ccrChart__legend-isLoading
 
-@import 'app/app';
+@import 'np_ready/app/app';

x-pack/legacy/plugins/cross_cluster_replication/public/app/app.js → x-pack/legacy/plugins/cross_cluster_replication/public/np_ready/app/app.js

@@ -7,7 +7,6 @@
 import React, { Component, Fragment } from 'react';
 import PropTypes from 'prop-types';
 import { Route, Switch, Redirect, withRouter } from 'react-router-dom';
-import { fatalError } from 'ui/notify';
 import { i18n } from '@kbn/i18n';
 import { FormattedMessage } from '@kbn/i18n/react';
 
@@ -21,7 +20,8 @@ import {
   EuiTitle,
 } from '@elastic/eui';
 
-import { BASE_PATH } from '../../common/constants';
+import { BASE_PATH } from '../../../common/constants';
+import { getFatalErrors } from './services/notifications';
 import { SectionError } from './components';
 import routing from './services/routing';
 import { loadPermissions } from './services/api';
@@ -81,7 +81,7 @@ class AppComponent extends Component {
       });
     } catch (error) {
       // Expect an error in the shape provided by Angular's $http service.
-      if (error && error.data) {
+      if (error && error.body) {
         return this.setState({
           isFetchingPermissions: false,
           fetchPermissionError: error,
@@ -90,7 +90,7 @@ class AppComponent extends Component {
 
       // This error isn't an HTTP error, so let the fatal error screen tell the user something
       // unexpected happened.
-      fatalError(
+      getFatalErrors().add(
         error,
         i18n.translate('xpack.crossClusterReplication.app.checkPermissionsFatalErrorTitle', {
           defaultMessage: 'Cross-Cluster Replication app',

x-pack/legacy/plugins/cross_cluster_replication/public/app/components/auto_follow_pattern_delete_provider.js → x-pack/legacy/plugins/cross_cluster_replication/public/np_ready/app/components/auto_follow_pattern_delete_provider.js

@@ -11,7 +11,7 @@ import { FormattedMessage } from '@kbn/i18n/react';
 import { EuiConfirmModal, EuiOverlayMask } from '@elastic/eui';
 
 import { deleteAutoFollowPattern } from '../store/actions';
-import { arrify } from '../../../common/services/utils';
+import { arrify } from '../../../../common/services/utils';
 
 class AutoFollowPatternDeleteProviderUi extends PureComponent {
   state = {

x-pack/legacy/plugins/cross_cluster_replication/public/app/components/auto_follow_pattern_form.js → x-pack/legacy/plugins/cross_cluster_replication/public/np_ready/app/components/auto_follow_pattern_form.js

@@ -29,8 +29,8 @@ import {
   EuiTitle,
 } from '@elastic/eui';
 
-import { indices } from '../../../../../../../src/plugins/es_ui_shared/public';
-import { indexPatterns } from '../../../../../../../src/plugins/data/public';
+import { indices } from '../../../../../../../../src/plugins/es_ui_shared/public';
+import { indexPatterns } from '../../../../../../../../src/plugins/data/public';
 
 import routing from '../services/routing';
 import { extractQueryParams } from '../services/query_params';

x-pack/legacy/plugins/cross_cluster_replication/public/app/components/auto_follow_pattern_page_title.js → x-pack/legacy/plugins/cross_cluster_replication/public/np_ready/app/components/auto_follow_pattern_page_title.js

@@ -17,7 +17,7 @@ import {
   EuiTitle,
 } from '@elastic/eui';
 
-import { autoFollowPatternUrl } from '../services/documentation_links';
+import { getAutoFollowPatternUrl } from '../services/documentation_links';
 
 export const AutoFollowPatternPageTitle = ({ title }) => (
   <Fragment>
@@ -35,7 +35,7 @@ export const AutoFollowPatternPageTitle = ({ title }) => (
           <EuiButtonEmpty
             size="s"
             flush="right"
-            href={autoFollowPatternUrl}
+            href={getAutoFollowPatternUrl()}
             target="_blank"
             iconType="help"
             data-test-subj="docsButton"

x-pack/legacy/plugins/cross_cluster_replication/public/app/components/auto_follow_pattern_request_flyout.js → x-pack/legacy/plugins/cross_cluster_replication/public/np_ready/app/components/auto_follow_pattern_request_flyout.js

@@ -26,7 +26,7 @@ import {
   EuiTitle,
 } from '@elastic/eui';
 
-import { serializeAutoFollowPattern } from '../../../common/services/auto_follow_pattern_serialization';
+import { serializeAutoFollowPattern } from '../../../../common/services/auto_follow_pattern_serialization';
 
 export class AutoFollowPatternRequestFlyout extends PureComponent {
   static propTypes = {