Remove application/text fallback for payload #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While technically a breaking change, this behavior was neither tested nor documented. It also caused bugs and unwanted behavior in case something went wrong during JSON serialization. See PR #23. If we ever want to support non-JSON payloads, that should probably be made explicit, e.g. by calling a different method, when an event is being published.
|
Please add a CHANGELOG item. Otherwise perfectly fine. |
jgraichen
approved these changes
May 16, 2019
|
Done in master. I'll leave the decision about version number to you. ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While technically a breaking change, this behavior was neither tested
nor documented. It also caused bugs and unwanted behavior in case
something went wrong during JSON serialization.
See PR #23.
If we ever want to support non-JSON payloads, that should probably be
made explicit, e.g. by calling a different method, when an event is
being published.