Skip to content
This repository has been archived by the owner on Aug 12, 2021. It is now read-only.

Roadmap: Allow clear to be called external to the component #13

Closed
wants to merge 2 commits into from

Conversation

thekevinbrown
Copy link
Contributor

@thekevinbrown thekevinbrown commented Nov 21, 2016

We have a need to be able to clear the signature from outside of the component. I noticed this was on your roadmap so I figured I'd contribute the code back.

This PR does two things:

  1. It exposes a prop that allows you to hide the in-built clear button. This prop defaults to false to preserve backwards compatibility.
  2. It exposes a method called clear() which can be called from JS to clear the contents of the signature.

I also removed 3 properties from RNSketchManager.h because they weren't being used.

Let me know if any changes would be helpful here, I'm happy to amend as needed!

This was referenced Nov 24, 2016
Closed
@thekevinbrown
Copy link
Contributor Author

Actually I'm going to move off of the master branch on my side, so I've opened up a new PR with the same changes from a different branch: #15

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant