Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cmd + c/v not working with alternate modifier keys in Mac OS #2

Closed
davidjgraph opened this issue Aug 23, 2017 · 24 comments
Closed

Cmd + c/v not working with alternate modifier keys in Mac OS #2

davidjgraph opened this issue Aug 23, 2017 · 24 comments

Comments

@davidjgraph
Copy link
Contributor

On mac cmd + c and cmd + v keyboard shortcuts aren't working for copy/paste. The menu does work.

@michaelmcdonald
Copy link

Some more details as I'm experiencing the same issue:
OPERATING SYSTEM: macOS Sierra (v10.12.6)
DRAWIO VERSION: v7.1.9
ISSUE: Any text field where text can be entered does not accept the keyboard hotkeys for copy / paste (CMD + C / CMD + V) on the desktop application. The web application works without issue.

@jgraph jgraph deleted a comment from DaOriSin Sep 3, 2017
@alderg
Copy link
Contributor

alderg commented Sep 5, 2017

Like you pointed out this is a bug in Electron (ie. copy/paste isn't working for any text element - which is what we use behind the scenes to integrate with the system clipboard), so we need to wait for them to fix this.

@jgraph jgraph deleted a comment from michaelmcdonald Sep 5, 2017
@davidjgraph
Copy link
Contributor Author

electron/electron#2308

@corymayer
Copy link

The shortcuts are still not working for me on the desktop version. I have the same keyboard setup as the person in this issue: #38

@alexhayes

This comment has been minimized.

@davidjgraph davidjgraph reopened this Aug 14, 2019
@davidjgraph
Copy link
Contributor Author

Issue for online version is ubuntu only, jgraph/drawio#262. If you can repeat on other OS, please provide environment on other project.

@cpierson-gnw
Copy link

cpierson-gnw commented Oct 23, 2019

Issue for online version is ubuntu only, jgraph/drawio#262. If you can repeat on other OS, please provide environment on other project.

OS: macOS Mojave 10.14.6 (18G87)
Desktop version: 12.1.0

Not only do shortcuts not work for me on desktop, I cannot copy and paste even using menu options. I get the same error when trying to duplicate a page.
Screen Shot 2019-10-23 at 12 31 39 PM

::edit:: I've confirmed this in the web client as well, same error, same exact behavior.

@alderg
Copy link
Contributor

alderg commented Oct 30, 2019

Does this happen only with a specific selection of cells or with any cell, like a single rectangle?

@cpierson-gnw
Copy link

No specific selection, happens with any. However, I was able to get it working on the web client but not desktop. I am using a plug-in that was not reloaded when I moved to a new machine. Loading the plug-in to the web client works, but does not fix the issue on desktop, even after closing, restarting, and confirming the plug-in on restart.

@alderg
Copy link
Contributor

alderg commented Oct 30, 2019

But without the plugin this error does not occur?

@cpierson-gnw
Copy link

Web browser

  • Without the plug-in, this error occurs 100% of the time, as I am attempting to copy something that was built using the plug-in.
  • With the plug-in, this error occurs 0% of the time.

Desktop client

  • Without the plug-in, this error occurs 100% of the time.
  • With the plug-in, this error occurs 100% of the time.

Desktop tells you after loading a plug-in, that it will be loaded on refresh. However, even after closing and reloading the app, the plug-in does not appear in the left sidebar, which makes me think it is a plug-in loading issue on the desktop client.

With all that said, however, the error message, "Illegal constructor" leaves a LOT to be desired. It is unclear to the end user what is necessary to resolve the issue, if anything. Of course, if nothing can be done by the end user to resolve, then a message asking them to reach out for support should be provided instead.

@alderg
Copy link
Contributor

alderg commented Oct 30, 2019

So the plugin produces invalid XML that is causing this error to appear?

@cpierson-gnw
Copy link

No, the plug-in doesn't load on desktop. See attached images, one from web browser, other from desktop. C4 Model is missing - the plug-in is here: https://tobiashochguertel.github.io/c4-draw.io/c4.js
Screen Shot 2019-10-30 at 10 24 22 AM
Screen Shot 2019-10-30 at 10 25 09 AM

@alderg
Copy link
Contributor

alderg commented Oct 30, 2019

But the file, ie the XML, was created using that plugin, then loaded into the desktop version? AFAIK the C4 plugin produces invalid XML, we have reached out to the author and asked for a fix some time ago.

@cpierson-gnw
Copy link

cpierson-gnw commented Oct 30, 2019

Correct, the file was created using that plug-in and then loaded into the desktop version where that plug-in is also installed.

If it produces invalid XML, why does it work on the web browser?

Additionally, my comment about error text still stands.

@alderg
Copy link
Contributor

alderg commented Oct 30, 2019

The desktop version does not load the plugin, it is sandboxed, and the plugin overrides the I/O system of the editor and defines special constructors, which are not available in the desktop if the plugin does not load.

@constantinov
Copy link

constantinov commented Nov 7, 2019

On mac cmd + c and cmd + v keyboard shortcuts aren't working for copy/paste. The menu does work.

have same issue when connecting an external usb keyboard to my mac. cmd + c and cmd + v keyboard shortcuts work on the original keyboard, but do not work on the external usb keyboard. cmd + c and cmd + v works fine in other apps.
The issue only exists when key modifiers enabled:
image

@jgraph jgraph deleted a comment from likaihz Dec 23, 2019
@LeungGeorge
Copy link

On mac cmd + c and cmd + v keyboard shortcuts aren't working for copy/paste. The menu does work.

have same issue when connecting an external usb keyboard to my mac. cmd + c and cmd + v keyboard shortcuts work on the original keyboard, but do not work on the external usb keyboard. cmd + c and cmd + v works fine in other apps.
The issue only exists when key modifiers enabled:
image

same problem。
but when press shortcuts at the right side cmd(alias of option), it works

@Cloudzay
Copy link

On mac cmd + c and cmd + v keyboard shortcuts aren't working for copy/paste. The menu does work.

have same issue when connecting an external usb keyboard to my mac. cmd + c and cmd + v keyboard shortcuts work on the original keyboard, but do not work on the external usb keyboard. cmd + c and cmd + v works fine in other apps.
The issue only exists when key modifiers enabled:
image

same problem。
but when press shortcuts at the right side cmd(alias of option), it works

exactly the same, version 12.6.5

@m-mohamedin
Copy link
Contributor

I cannot reproduce the issue on 10.15.6 with an external KB using the same key modifier.

Can anyone confirm it is still an issue?

@imageslr
Copy link

Still an issue in 10.15.5, please see #326 (comment)

@EgleKat
Copy link

EgleKat commented Oct 29, 2020

Still an issue in 13.7.9

@e-desouza
Copy link

e-desouza commented Jan 17, 2021

Still an issue with 14.1.8. Doesn't even work if I change App Shortcuts for it on OSX (tried changing to ⌥C and ⌥V). It did work intermittently though - approx 1 every 15 attempts.

Workaround : Install the Draw.io Integration for VS Code ! As close as it comes to an offline version of this working remapped keys.

@m-mohamedin
Copy link
Contributor

The MacOS external keyboard copy/paste issue will be fixed in the next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests