Please publish Automatic-Module-Name manifest entries

[io7m]

Hello!

It'd be great if jgrapht published Automatic-Module-Name entries in the jar manifest for each module. This would assign the modules stable names to be used in (modular) Java 9 projects.

[jkinable]

Although I'm not familiar yet with Java 9 modules, this should be relatively easy (simply add one line to our pom files): http://branchandbound.net/blog/java/2017/12/automatic-module-name/
For the module name, I think org.jgrapht makes sense?
Any idea which POM files we should include this module name code (all?)?

[jkinable]

@io7m would you be willing to submit a pull request which takes care of this issue?

[io7m]

Hi.

Apologies, it seems like your response got buried in amongst all of the noise I receive from GitHub. I can certainly submit a PR that should address your questions.

[io7m]

@jkinable Would you be opposed to requiring JDK 9 to build the project? This would be strictly limited to building from source; the project would still only require JDK 8 to run.

There are two reasons to do this:

1. JDK 9 has a -release flag which performs checks of API usage. For example, if you were using JDK 8 and were wanting to produce JDK 6 bytecode, you could specify -source 1.6 and -target 1.6, but nothing would stop you accidentally using APIs that were only present in JDK 8. This would come as a nasty shock when people actually running a 1.6 VM tried to run your code. The -release flag prevents the above from happening; you are statically prevented from using any API that is not present in the targeted release.

2. The project doesn't currently build on JDK 9 at all due to the use of the obsolete javax.annotation.Generated annotation. There's a workaround for this, but in my opinion, it's less pleasant than just requiring JDK 9 up-front and using the new JDK 9-specific equivalent (javax.annotation.processing.Generated).

[io7m]

To clarify: I originally mentioned adding Automatic-Module-Name entries, but I think that full modularization is possible once a couple of your dependencies have been updated.

[jkinable]

@io7m the issue with the javax.annotation.Generated has been fixed. The project now builds correctly using JDK9. It still seems a little early to enforce JDK9 to build the project (after all, JDK9 was only officially released a few months ago). Would it be possible to implement the full modularization without requiring JDK9?

[io7m]

@jkinable Yes, modularization is possible without requiring JDK 9, it's just slightly more complicated. Not a problem!