Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opt fixes and specifics strategy simplification #665

Merged
merged 4 commits into from
Sep 3, 2018

Conversation

d-michail
Copy link
Member

Main changes

  • Simplified the specifics strategy interface and implementations
  • Fixed a bug when using the FastUtil map classes (we were using reference equality instead of .equals())
  • Added a graph implementation specialized for Integer vertices which uses the more specialized integer keyed map implementation of fastutil.
  • Moved all classes using FastUtil into a separate .fastutil package.

@jsichi I am having some trouble naming the graph classes. I used the pattern FastutilMap - IntegerAny - Graph where the Integer is the vertices type and the Any is the edges type. Does this make any sense? What about the first part? Should I shorten it, remove it, etc?


@jsichi
Copy link
Member

jsichi commented Aug 29, 2018

How about this convention:

  • FastutilMapIntVertexGraph (implies edge type is unrestricted)
  • FastutilMapIntVertexLongEdgeGraph (edge type is specialized to long)

(Let's follow the fastutil typename convention Int, Long, etc)

For GraphSpecificsStrategy, acronymization to GSS is probably called for.

@d-michail
Copy link
Member Author

I renamed the classes, per your suggestion. I also moved a few tests from the new isomorphism package to the slow tests category, because the test phase was getting slow again.

@jsichi
Copy link
Member

jsichi commented Sep 3, 2018

Thanks!

@jsichi jsichi merged commit 32dd8f3 into jgrapht:master Sep 3, 2018
@d-michail d-michail deleted the opt-fixes branch September 3, 2018 09:08
@syoon2 syoon2 mentioned this pull request Apr 12, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants