Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The search phrase "class" returns all results. #7

Open
jgreenemi opened this issue Feb 2, 2018 · 1 comment
Open

The search phrase "class" returns all results. #7

jgreenemi opened this issue Feb 2, 2018 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@jgreenemi
Copy link
Owner

I suspect this is a side effect of the search logic taking each resource's div tag and searching the text for matches of the search words, since there is a class property in each of those elements. Since "class" is a valid search phrase when looking for resources from educational facilities/school-provided resources, this limitation should be removed.

This will probably involve pulling the .text from each tag and using that as the search, rather than simply grabbing the #resource_box object's div children, and as such is not a terribly involved task.

@jgreenemi jgreenemi added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers labels Feb 2, 2018
@jgreenemi
Copy link
Owner Author

In the simple-filter.js file, the this.innerHTML line will need to be pulled out and replaced with logic to pull the text content of the tag(s) involved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant