Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PQT = 0 in setPromiscuous #1033

Merged
merged 4 commits into from
Mar 26, 2024
Merged

PQT = 0 in setPromiscuous #1033

merged 4 commits into from
Mar 26, 2024

Conversation

Crsarmv7l
Copy link
Contributor

Sets PQT to 0 in setPromiscuous(true)

@Crsarmv7l
Copy link
Contributor Author

Crsarmv7l commented Mar 25, 2024

I included the bool for the two carriersense options for promiscuous that I mentioned in the discussion (in my main branch). If you are open to it I can cancel this pull and submit both this and that as one pull request.

@jgromes
Copy link
Owner

jgromes commented Mar 25, 2024

Thanks for the contribution! I think the option for carrier sense can be added directly in this PR. Please make sure it is set to to false when calling setPromiscuousMode without arguments.

@Crsarmv7l
Copy link
Contributor Author

Thanks for the contribution! I think the option for carrier sense can be added directly in this PR. Please make sure it is set to to false when calling setPromiscuousMode without arguments.

Should be good to go, let me know if there are any issues. Thank you for your patience, willingness to help and acceptance of some small but nice to have changes!

@jgromes jgromes merged commit b3ed84a into jgromes:master Mar 26, 2024
30 checks passed
@jgromes
Copy link
Owner

jgromes commented Mar 26, 2024

Merged, thank you for the contribution!

@Crsarmv7l Crsarmv7l deleted the pull branch March 27, 2024 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants