-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add consult-org-roam-buffer #13
Conversation
Add consult-org-roam-buffer to fix #12
Starting to look into this. Thanks! Quick first question: what do you think about the issue of having org-roam buffers buried all the way after Here's a rough proposal adapting your own suggestion in the original discussion: (defcustom consult-org-roam-buffer-after-buffers nil
"If non-nil, display org-roam buffers right after non-org-roam buffers.
Otherwise, display org-roam buffers after any other visible default
source")
(defun consult-org-roam-buffer-setup ()
(if consult-org-roam-buffer-after-buffers
(let* ((idx (cl-position 'consult--source-buffer consult-buffer-sources :test 'equal))
(tail (nthcdr idx consult-buffer-sources)))
(setcdr
(nthcdr (1- idx) consult-buffer-sources)
(append (list 'org-roam-buffer-source) tail)))
(add-to-list 'consult-buffer-sources 'org-roam-buffer-source 'append)))
Final question (for now!): what do you think about propertizing the output of |
Glad to hear.
I created a
This is very sensible I think.
Great, I added this in 401f68e.
Good idea. Should we make it completely invisible? Best regards, |
Yes, sorry, I realized this after posting (not sure how I didn't see it when I checked the value of
Great!
I think that would be great. It's a bit of an edge case anyway, having same title in different buffers, and the noise from the hashes is a bit much (I think). Best, A.
|
Nevermind, it was not that obvious anyways.
I completely agree and added this in commit 2803df5. After extending the documentation and checking that it is working out of the box when installed via straight or melpa we are good to go I think. Thanks again for kicking this off...I think it is a really helpful feature. Sure, one could just use Best regards, |
Nice! Something is a bit off now, though: after opening a single org-roam-buffer, the source lists it twice. Let me see if I can figure out what's going on. Will write back. |
Just reporting, in the meantime, that there's something weird going on with my config at the moment, so that may be part of the problem. |
Okay, I can't reproduce that.
This could be an issue, take your time to inspect that and please tell me if you find any issue. |
I'm baffled here. I now have set I was having some issues earlier with
So I do not understand how it could be showing up twice on the list of buffers. I'll keep digging but if you have any clues, let me know. |
That's really weird. Again, I cannot reproduce the issue.
Unfortunately, I have no clue what might be going on here. |
OK, I think I figured out what's going on. The problem is that if you set I guess one way to avoid this would be to change the definition of
Not sure this is the best or the canonical way to do this sort of thing though. Unrelated: the minimal config you linked to is quite helpful, but it sets the value of |
Thanks for investigating this. I could reproduce it by changing the defcustom and manually re-evaluation
I think this is viable to do. I just hat to quote the symbol (setq consult-buffer-sources
(delete 'org-roam-buffer-source consult-buffer-sources)) Commit 3eee411 should fix the problem, can you confirm that?
Thanks for the notice. I changed that path to Best regards, |
OK, so far so good! My only question is whether there's a clearer way of indicating that a file has been deleted than "not persisted". I for one wouldn't have known what to make of this had I encountered it. What about simply "file deleted"? About the test config, have you considered just having some test files that can be downloaded as part of the repo, which could be what |
Thanks for looking at it again.
I think populating a Best regards, |
Add
consult-org-roam-buffer.el
to address #12 and provide the ability to use a custom source for org-roam-notes withconsult-buffer
.This is related to #12 and to #660 opened by @apc at the consult repo.