Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifiers for form elements #11

Closed
wlepinski opened this issue Jan 28, 2016 · 12 comments
Closed

Modifiers for form elements #11

wlepinski opened this issue Jan 28, 2016 · 12 comments
Labels

Comments

@wlepinski
Copy link

Would be nice to have .is-primary, .is-info, .is-success, .is-warning and .is-danger as .control modifiers.

@jgthms
Copy link
Owner

jgthms commented Jan 28, 2016

So .control is only the container for <input>, <select> <button>... It has no actual styling (apart from some margin).

Do you mean have colours for .input, .select, .textarea, .checkbox and .radio?

@wlepinski
Copy link
Author

@jgthms Exactly. I'm creating a PR with this modification :)

@omgaz
Copy link

omgaz commented Feb 5, 2016

I assume this would be for field validation e.g. a red border should the field be invalid?

@wlepinski
Copy link
Author

@omgaz yes. That's the idea.

@marcoskubis
Copy link

Would be nice something like this codepen.

@jgthms
Copy link
Owner

jgthms commented Feb 20, 2016

@marcoskubis Haha that's very nice! I'll add it. Just a couple of lines.

@marcoskubis
Copy link

Great! And congratulations for your Bulma project. I'll use in my projects.

@jgthms
Copy link
Owner

jgthms commented Feb 22, 2016

This has been added.

@jgthms jgthms closed this as completed Feb 22, 2016
@ashnur
Copy link

ashnur commented Feb 23, 2016

The styling for the .help message from the codepen was not added. I assume that was left out intentionally? I am just wondering if there is already something like that to inherit parent's styling?

@jgthms
Copy link
Owner

jgthms commented Feb 23, 2016

Ah yes I forgot that. I'll add it in a few days.

@ashnur
Copy link

ashnur commented Feb 23, 2016

This is a nice thing to have so I don't have to put .is-danger everywhere : ).
However I am not sure about .help as class for this feature. I would think that this is for a feedback, a status message. Help is something I can show before any interaction, while these modifiers are mostly about interactions.

@kimroen
Copy link

kimroen commented Feb 23, 2016

I would think that this is for a feedback, a status message.

I would agree. .help is a permanent thing, but this is a temporary message that will go away once the temporary state of the error goes away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants