Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hero with is-fullheight-with-navbar combined with is-spaced navbar #2845

Closed
robbertkl opened this issue Feb 24, 2020 · 2 comments
Closed

Hero with is-fullheight-with-navbar combined with is-spaced navbar #2845

robbertkl opened this issue Feb 24, 2020 · 2 comments
Labels

Comments

@robbertkl
Copy link

A hero with is-fullheight-with-navbar only accounts for a normal fixed navbar, not for a is-spaced navbar.

I've managed to work around it by adding this to my scss:

.is-fullheight-with-spaced-navbar {
  @extend .is-fullheight-with-navbar;
}
@media screen and (min-width: 1024px) {
  .hero.is-fullheight-with-spaced-navbar {
    min-height: calc(100vh - 5.25rem);
  }
}

Perhaps a class like this could be incorporated into bulma?

@maduhaime
Copy link

maduhaime commented Mar 11, 2020

This is my take on the same problem, with the use of scss and variables.

/* 
Hack for missing modifier for fullheight hero with spaced navbar.
By default, .is-spaced has no effect on Navbar padding.  Only from $tablet.
*/
.hero {
  &.is-fullheight-with-spaced-navbar {
    @extend .is-fullheight-with-navbar;

    @include from($tablet) {
      min-height: calc(100vh - ( #{$navbar-height} + ( 2 * #{$navbar-padding-vertical} ) ) );
  }
}

@stale
Copy link

stale bot commented Sep 7, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants