Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Columns gap does nothing on mobile #3256

Closed
northamerican opened this issue Feb 1, 2021 · 5 comments
Closed

Columns gap does nothing on mobile #3256

northamerican opened this issue Feb 1, 2021 · 5 comments
Labels

Comments

@northamerican
Copy link

This is about Bulma 0.9.2

Columns gaps are set using a class like columns is-variable is-1. In the documentation, gaps can be set on mobile display sizes using a -mobile helper: columns is-variable is-1-mobile. However on mobile, columns are stacked by default. So in the example in the documentation, is-1-mobile does nothing to change the layout. To reproduce, change that class to is-3-mobile and see how it has no effect on the layout.

My intent is that on mobile there is a vertical gap between each column but it seems like Bulma does not offer such functionality. At all sizes, the --columnGap is set on the left and right padding but not top and bottom.

padding-left: var(--columnGap);
padding-right: var(--columnGap);

Either the documentation should clarify that is-n-mobile does nothing without is-mobile, or such functionality to adjust vertical gap at mobile viewport should be introduced.

I can file a PR if such a feature makes sense.

@letsbuildafire
Copy link

This PR fixes the responsive horizontal gaps #3202

@northamerican
Copy link
Author

thanks @letsbuildafire, i'll close this issue.

@northamerican
Copy link
Author

northamerican commented Feb 1, 2021

Actually this is not the same thing, @letsbuildafire.

My issue is that the gaps have no effect on mobile at all. On mobile, is-n-mobile should insert more space between each column on the top and bottom - or an option for such thing should be provided.

Something like

.columns.is-variable .column
  @include mobile
    padding-top: var(--columnGap);
    padding-bottom: var(--columnGap);

@northamerican northamerican reopened this Feb 1, 2021
@letsbuildafire
Copy link

Yeah, it fixes the horizontal gaps. I didn't add in vertical gaps as that would have been a new feature. But I'm all for being able to adjust vertical gaps too.

@stale
Copy link

stale bot commented Aug 3, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Aug 3, 2021
@stale stale bot closed this as completed Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants