Fix/divide #3362
Merged
Fix/divide #3362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniil4udo
pushed a commit
to daniil4udo/bulma-css-variables
that referenced
this pull request
Jun 21, 2021
* Use custom divide function * Add docs spacing table styles * Update changelog
MartinRosenberg
added a commit
to Collabsalot/gatsby-starter-i18n-bulma
that referenced
this pull request
Sep 7, 2021
See issue @ jgthms/bulma#3333 See bugfix PR @ jgthms/bulma#3362
kalwalt
pushed a commit
to kalwalt/gatsby-starter-i18n-bulma
that referenced
this pull request
Sep 13, 2021
See issue @ jgthms/bulma#3333 See bugfix PR @ jgthms/bulma#3362
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bugfix.
Dart Sass is deprecating slash divisions.
Proposed solution
Using a custom
divide()function to avoid using a slash/.Using multiplication
*instead where easy/possible.Tradeoffs
Testing Done
CSS output is similar.
Changelog updated?
Yes.