Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

button: is-loading does not work with is-light #3676

Open
gabrc52 opened this issue Sep 4, 2023 · 7 comments
Open

button: is-loading does not work with is-light #3676

gabrc52 opened this issue Sep 4, 2023 · 7 comments

Comments

@gabrc52
Copy link

gabrc52 commented Sep 4, 2023

This is about Bulma.

Overview of the problem

This is about the Bulma CSS framework

I'm using Bulma version 0.9.4
My browser is: Firefox / Chrome

Similar to #3637 but for is-light rather than is-inverted

Description

Steps to Reproduce

Observe the following:

<button class="button is-loading is-link is-light">hello world</button>

or

<button disabled class="button is-loading is-link is-light">hello world</button>

(I assume it makes sense to disable the button if it is loading)

Code in the screenshot
Loading:
<div class="section">
	Disabled:
	<button disabled class="button is-loading is-link is-light" on:click={doNothing}>Hello world</button>
	<button disabled class="button is-loading is-link" on:click={doNothing}>Hello world</button>

	Not disabled:
	<button class="button is-loading is-link is-light" on:click={doNothing}>Hello world</button>
	<button class="button is-loading is-link" on:click={doNothing}>Hello world</button>
</div>
Not loading:
<div class="section">
	Disabled:
	<button disabled class="button is-link is-light" on:click={doNothing}>Hello world</button>
	<button disabled class="button is-link" on:click={doNothing}>Hello world</button>

	Not disabled:
	<button class="button is-link" on:click={doNothing}>Hello world</button>
	<button class="button is-link" on:click={doNothing}>Hello world</button>
</div>

Expected behavior

The loading indicator is solid and visible (the same color as the outline or the background of the non-light variant)

Actual behavior

The loading indicator is solid and barely visible

image

@abreel
Copy link

abreel commented Sep 5, 2023

@gabrc52 mind if we try to fix this together? Who do I tag for contribution?

@ariejan @aredridel @nuin @MikeRalphson, can I look into this?

@aredridel
Copy link
Contributor

I'm not a decision maker on this project.

@gabrc52
Copy link
Author

gabrc52 commented Sep 5, 2023

@abreel I don't know CSS yet but can help look into it :)

@abreel
Copy link

abreel commented Sep 8, 2023

@gabrc52 That would be nice

@aredridel Okay, that's fine. Please could you point me in the direction of the right person to tag? Just to inform a decision maker and get a go ahead?

@aredridel
Copy link
Contributor

@abreel it's really not my project. I am just an end user.

@RintuNoelmon
Copy link

@gabrc52 Hi, I would like to work on this issue. Is it still open?

@gabrc52
Copy link
Author

gabrc52 commented Nov 21, 2023

Yes it's open, I'm not working on this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants