Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix assumptions for colors of elements and components #733

Open
CaitlinWeb opened this issue May 8, 2017 · 0 comments
Open

Fix assumptions for colors of elements and components #733

CaitlinWeb opened this issue May 8, 2017 · 0 comments
Assignees

Comments

@CaitlinWeb
Copy link

Overview of the problem

This is about the Bulma CSS framework

I'm using Bulma version [0.4.1]

This is a Sass issue: I'm using version [0.4.1]
I am sure this issue is not a duplicate?

Description

I'm really liking the modularity and breadth of styles available with Bulma. Rock on.

The only issue preventing me from using it is that there are a lot of assumptions about color scheme. Some of the issue is mentioned in #720 but the full problem is really assuming that every design has a white background. What I mean is that not only are backgrounds all set to white but the text colors are also set to a dark color.

So, if I want a nav bar with a blue background, the links are grey and hard to see. (Worse, if I use the primary color as the background and .is-tab then the text and border is the same color!) To fix it I would have to override $text-light, which is used throughout the Sass files and could cause far-reaching issues.

It's not just isolated to the nav component. For example, tab links use $text which is what you also set the body text to be; that may not be what you want the tab link to be colored.

Instead of using the above broad variables there should be a variable for backgrounds and/or text for each component and element. The default could be white with dark text. You could probably simplify it by using findColorInvert() for text (which is super nifty).

@jgthms jgthms self-assigned this May 10, 2017
@jgthms jgthms added the bulma label Jun 27, 2017
@jgthms jgthms added pinned and removed pinned labels Jan 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants