Skip to content

Commit

Permalink
Update to minimap v2.27
Browse files Browse the repository at this point in the history
  • Loading branch information
@jguhlin
jguhlin committed Mar 12, 2024
1 parent a970aaf commit 96236cc
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
2 changes: 1 addition & 1 deletion Cargo.toml
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "minimap2"
version = "0.1.16+minimap2.2.26"
version = "0.1.17+minimap2.2.27"
edition = "2021"
authors = ["Joseph Guhlin <joseph.guhlin@gmail.com>"]
license = "MIT OR Apache-2.0"
Expand Down
5 changes: 5 additions & 0 deletions README.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,11 @@ and/or:
> *Bioinformatics*, **37**:4572-4574. [doi:10.1093/bioinformatics/btab705][doi2]
# Changelog
### 0.1.17 minimap2 2.27
* Mark bam::Record objects as supplementary. #52 @PB-DB
* Only use rust-htslib/curl when curl feature is enabled. #53 @PB-DB
* Update to minimap2 v2.27 @jguhlin

### 0.1.16 minimap2 2.26
* Much better cross compilation support thanks to @Adoni5

Expand Down

6 comments on commit 96236cc

@Ge0rges
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, has this version been published to the registry? Cargo cant' seem to find 0.1.17+minimap2.2.27

@jguhlin
Copy link
Owner Author

@jguhlin jguhlin commented on 96236cc Mar 15, 2024 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ge0rges
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, thank you!

@jguhlin
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ge0rges Minimap 2.27 has introduced a strange bug, that only occurs in --release mode

So cargo test works, cargo test --release fails. This may take a bit of time to debug, although hopefully it's solved in a day or two!

"process didn't exit successfully: /mnt/data/development/minimap2-rs/minimap2-sys/target/release/deps/minimap2_sys-39c0cae99373aa42 (signal: 11, SIGSEGV: invalid memory reference)"

@jguhlin
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ge0rges nevermind, it was an issue with mm2-fast headers overwriting minimap2 headers, and being incompatible (now). Fixed, and release has been pushed out!

@Ge0rges
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great glad you caught it, I was just sitting down to look at this and the Async feature. Will get back to the latter in a sec.

Please sign in to comment.