Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unhandled Promise rejection Error #8

Closed
jh3y opened this issue Nov 18, 2016 · 0 comments
Closed

Unhandled Promise rejection Error #8

jh3y opened this issue Nov 18, 2016 · 0 comments

Comments

@jh3y
Copy link
Owner

jh3y commented Nov 18, 2016 •
edited
Loading

Issue summary

Noticed when firing one of the tasks on my own kody_envfor installing apm packages.

More info on this error here. From what I can tell, the task is still successfully carried out but we just get the error noise in addition at the end.

I think the solution is to make processTask within processTasks potentially return a promise so that a rejection error can be handled.

Expected behavior

Runs with no errors or noise.

Actual behavior

We get noise 😢

Steps to reproduce

Personally, I ran the install apm package installer task from https://github.com/jh3y/kody_env.

@jh3y
jh3y added a commit that referenced this issue Jul 22, 2018
@jh3y
feature: v2 overhaul - resolves #1 #5 #6 #7 #8 #9
3d65484 
- no longer prepend dotfiles, leave to user definition
- improve unhandled rejection error cases
- overhaul README
- improve overall logging to user for scenarios such as no task selected
- overhaul symlinking task and provide backup option
- fix issue where file already in place when attempting to symlink by removing/restoring backup
@jh3y jh3y mentioned this issue Jul 22, 2018
Merged
jh3y added a commit that referenced this issue Jul 22, 2018
@jh3y
feature: v2 overhaul - resolves #1 #5 #6 #7 #8 #9
784bfe8 
- no longer prepend dotfiles, leave to user definition
- improve unhandled rejection error cases
- overhaul README
- improve overall logging to user for scenarios such as no task selected
- overhaul symlinking task and provide backup option
- fix issue where file already in place when attempting to symlink by removing/restoring backup
jh3y added a commit that referenced this issue Jul 22, 2018
@jh3y
feature: v2 overhaul - resolves #1 #5 #6 #7 #8 #9
43f8f6e 
- no longer prepend dotfiles, leave to user definition
- improve unhandled rejection error cases
- overhaul README
- improve overall logging to user for scenarios such as no task selected
- overhaul symlinking task and provide backup option
- fix issue where file already in place when attempting to symlink by removing/restoring backup
jh3y added a commit that referenced this issue Jul 22, 2018
@jh3y
feature: v2 overhaul - resolves #1 #5 #6 #7 #8 #9
f896802 
- no longer prepend dotfiles, leave to user definition
- improve unhandled rejection error cases
- overhaul README
- improve overall logging to user for scenarios such as no task selected
- overhaul symlinking task and provide backup option
- fix issue where file already in place when attempting to symlink by removing/restoring backup
jh3y added a commit that referenced this issue Jul 22, 2018
@jh3y
feature: v2 overhaul - resolves #1 #5 #6 #7 #8 #9
d5122dc 
- no longer prepend dotfiles, leave to user definition
- improve unhandled rejection error cases
- overhaul README
- improve overall logging to user for scenarios such as no task selected
- overhaul symlinking task and provide backup option
- fix issue where file already in place when attempting to symlink by removing/restoring backup
jh3y added a commit that referenced this issue Jul 22, 2018
@jh3y
feature: v2 overhaul - resolves #1 #5 #6 #7 #8 #9
0b25c2d 
- no longer prepend dotfiles, leave to user definition
- improve unhandled rejection error cases
- overhaul README
- improve overall logging to user for scenarios such as no task selected
- overhaul symlinking task and provide backup option
- fix issue where file already in place when attempting to symlink by removing/restoring backup
jh3y added a commit that referenced this issue Jul 22, 2018
@jh3y
feature: v2 overhaul - resolves #1 #5 #6 #7 #8 #9
7da6bc8 
- no longer prepend dotfiles, leave to user definition
- improve unhandled rejection error cases
- overhaul README
- improve overall logging to user for scenarios such as no task selected
- overhaul symlinking task and provide backup option
- fix issue where file already in place when attempting to symlink by removing/restoring backup
@jh3y jh3y closed this as completed Jul 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jh3y