Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow merges if pr.mergeable_state == 'has_hooks' #37

Merged
merged 1 commit into from
Sep 3, 2018
Merged

Allow merges if pr.mergeable_state == 'has_hooks' #37

merged 1 commit into from
Sep 3, 2018

Conversation

stalar
Copy link
Collaborator

@stalar stalar commented Jul 6, 2018

This change allows merges to proceed even if the mergeable_state is reported as 'has_hooks'.

In GitHub Enterprise, global pre-receive hooks can be defined that can disallow pushes. When such hooks are defined, the github api will report the mergeable_state as 'has_hooks' instead of 'clean'. The meaning of this is "You can push this merge, but the pre-receive hook may disallow it". Tutter should allow this state in the same way as a 'clean' state.

@stalar stalar closed this Aug 14, 2018
@stalar stalar reopened this Aug 14, 2018
@jhaals jhaals merged commit 3e8a02c into jhaals:master Sep 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants