Iterating of the map should not throw a ConcurrentModificationException #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create a copy of the entries (guarded by a readLock) and iterate over that copy. This fixes #10
|
@jhalterman this PR is open for some time now, have you had time to look into this? |
|
Thanks for this, and sorry for the huge delay. I don't love copying the map, but I agree with your point that thread safety is priority, so this is better than ConcurrentModificationException for now. I'll add a note about the copying behavior to the Javadoc and cut a new release. |
|
This is released in 0.5.11. |
bratkartoffel
added a commit
to bratkartoffel/expiringmap
that referenced
this pull request
Dec 5, 2023
This is an addition to the fix implemented with jhalterman#78 which did not cover all cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a copy of the entries (guarded by a readLock) and iterate over that copy.
This fixes #10 and maybe #30 (needs further testing though, couldn't reproduce that)
Create a copy of the underlying map and iterate over that, never throwing a ConcurrentModificationException. This comes with a small performance penalty though (copying the map content to new instance) but fixing the exception should have priority as this violates the contract of this class (threadsafe)