WIP: Metrics collector for Circuit Breaker

[slayful]

No description provided.

[coveralls]

Coverage decreased (-1.4%) to 85.972% when pulling 3b4a0aa on slayful:metrics-collector into e3c37eb on jhalterman:master.

[whiskeysierra]

I wouldn't design/implement this with just metrics in mind. Why not add more extensive listener/callback support to the circuit breaker (similar to retries) and people can use that for metrics or anything else then.

[vgoldin]

Whenever as a generic mechanism, or specific to circuit breakers, metrics would be highly valuable. In addition, creating hystrix compatible stream would allow plugging it into hystrix dashboard

[sunng87]

I wish we can make this generic and keep failsafe self-contained. Give listener to user allows integration with any metrics provider.

[jhalterman]

@sunng87 @whiskeysierra Any particular listeners you had in mind for this?

[MALPI]

Probably this should be made explicit?

[jhalterman]

You mean the wildcard import? My IDE does this too if there are several imports from the same package. The runtime cost should be nil.

[MALPI]

@jhalterman I would make it more generic so that we can measure as well how long an attempt took.

[jhalterman]

@MALPI #104 currently looks to add elapsed attempt time to ExecutionContext, so we'd just need an onComplete listener for CircuitBreaker in order to access that.

This gets back to #154 where it might be nice to have separate event listeners for each Policy (such as CircuitBreaker) :)

[jhalterman]

Closing as obsolete for now.