Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Either recycle or close consumer threadpools after recovering connections #23

Closed
jhalterman opened this issue Nov 28, 2013 · 0 comments
Closed

Either recycle or close consumer threadpools after recovering connections #23

jhalterman opened this issue Nov 28, 2013 · 0 comments
Milestone
0.3.3

Comments

@jhalterman
Copy link
Owner

If a user does not specify a consumer threadpool, we create a named threadpool on their behalf, which is considered by amqp-client to be user-owned, and therefore must be shutdown by us when we're done with it. Therefore we should either close or recycle this thread pool when recovering connections.
jhalterman added a commit that referenced this issue Dec 13, 2013
@jhalterman
Recycle connection pools.
af215cd 
Shutdown Lyra created connection pools after the connection is closed and cannot be recovered.
Fixes issue #23.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.3.3
Development

No branches or pull requests
1 participant
@jhalterman