Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clone() stuff #1

Closed
wants to merge 4 commits into from
Closed

clone() stuff #1

wants to merge 4 commits into from

Conversation

jmmills
Copy link
Contributor

@jmmills jmmills commented Sep 23, 2010

Sorry it took me so long to get to fixing this. Sort of left my orbit.
It seems that Clone::Fast was having some issues so I simplified the whole interface to just use Storable::dclone which is both mature and available in core (from forever ago).
The original idea behind having a chain of available "cloning drivers" was to leverage Clone::Fast's performance when available on the system; since the operation is happening on a row by row level it seems like something important.
But, for now it's probably just to get the interface update out their and worry about performance increases later.

Thanks,

  • J

p.s. I'm still confused as to what broke with Clone::Fast - I will have to dig further and take up any issue I find with that dist's author.

$ perl -v && prove t

This is perl 5, version 12, subversion 2 (v5.12.2) built for x86_64-linux
(with 7 registered patches, see perl -V for more detail)

Copyright 1987-2010, Larry Wall

Perl may be copied only under the terms of either the Artistic License or the
GNU General Public License, which may be found in the Perl 5 source kit.

Complete documentation for Perl, including FAQ lists, should be found on
this system using "man perl" or "perldoc perl". If you have access to the
Internet, point your browser at http://www.perl.org/, the Perl Home Page.

===( 1;0 1/1 0/31 0/42 0/? 0/? )===========================# Testing Text::FixedWidth 0.07, Perl 5.012002, /usr/bin/perl5.12.2
t/00-load.t ....... ok
t/boilerplate.t ... ok
t/11-clone.t ...... ok
t/10-basic.t ...... ok
t/pod-coverage.t .. ok
t/pod.t ........... ok
All tests successful.
Files=6, Tests=79, 0 wallclock secs ( 0.07 usr 0.02 sys + 0.33 cusr 0.05 csys = 0.47 CPU)
Result: PASS

@jhannah
Copy link
Owner

jhannah commented Sep 28, 2010

Merged and pushed to PAUSE as 0.07_01. Thanks!

http://static.cpantesters.org/distro/T/Text-FixedWidth.html

@jmmills
Copy link
Contributor Author

jmmills commented Oct 18, 2010

Oi! Just noticed a install failure on a vanilla debian install and noticed that the 11-clone.t test fails do to a stale version of Test::More (doesn't include new_ok test) shipped with the distro.
Figure there are two possible solutions:
a) Set a min version in the Makefile.PL's requires
b) Modify the test to do what new_ok does manually

@jhannah
Copy link
Owner

jhannah commented Oct 19, 2010

I removed new_ok() and pushed it. b54a3d2 Thanks! :)

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants