Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding tests for Postgres schema generation #107

Merged
merged 9 commits into from
Jan 29, 2020

Conversation

sashman
Copy link
Contributor

@sashman sashman commented Jan 1, 2020

Using pagila, sql dump added to repo, as an example. The tests rely on an available database with the sql dump imported. I suggests the following docker command:

docker run --name plsm-postgres-test -e POSTGRES_PASSWORD=postgres -p 5432:5432 -v `pwd`/test/support/schemas/postgres:/docker-entrypoint-initdb.d --rm postgres

Once this is up and running, you can use:

mix test

So far only one test has been implemented since plsm doesn't generate compliable code from this :(. #101 definitely fixes an issue.

What are your thoughts @jhartwell? I think we need to tackle #53 step by step.

@sashman sashman changed the title Adding tests Adding tests for Postgres schema generation Jan 5, 2020
@sashman sashman mentioned this pull request Jan 5, 2020
@sashman sashman mentioned this pull request Jan 15, 2020
@sashman sashman marked this pull request as ready for review January 26, 2020 00:19
@sashman
Copy link
Contributor Author

sashman commented Jan 26, 2020

@jhartwell rebased, just bear in mind these are first steps towards getting a full test suite, as it stands running mix test will very likely fail

@jhartwell jhartwell merged commit 9381eed into jhartwell:master Jan 29, 2020
@sashman sashman deleted the adding_tests branch January 30, 2020 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants