Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests to project #53

Open
jhartwell opened this issue Sep 21, 2017 · 4 comments
Open

Add tests to project #53

jhartwell opened this issue Sep 21, 2017 · 4 comments
Assignees
@jhartwell @sashman
Labels
enhancement help wanted

Comments

@jhartwell
Copy link
Owner

Currently there are no tests and that is a problem as we are relying on contributors to set up their database and test. Now, connecting to a database is going to be difficult to test as well as the query but the output is easy to test using mocks.
@jhartwell jhartwell added this to the 2.1.0 milestone Sep 21, 2017
@jhartwell jhartwell self-assigned this Sep 21, 2017
@jhartwell jhartwell modified the milestones: 2.1.0, 2.2.0 Nov 29, 2017
@jhartwell jhartwell modified the milestones: 2.2.0, 2.2.2 Dec 15, 2017
@sashman
Copy link
Contributor

sashman commented Dec 10, 2019

@jhartwell I can give you a hand with this if you don't mind?

@jhartwell jhartwell removed this from the 2.2.2 milestone Dec 10, 2019
@jhartwell
Copy link
Owner Author

@sashman knock yourself out. It would be nice to have several SQL files that will allow somebody to easily populate the database with the test data in order to run the test suite

@sashman sashman mentioned this issue Jan 5, 2020
Merged
@sashman
Copy link
Contributor

sashman commented Jan 15, 2020

@jhartwell any thoughts on #107 ?

@jhartwell
Copy link
Owner Author

@sashman , sorry for the delay. That PR looks good. Please rebase with master and open a non-draft PR. Thanks for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhartwell jhartwell

@sashman sashman

Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jhartwell @sashman