Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vernier.prof compare interface doesn't respect tilde #79

Open
zenspider opened this issue Jul 14, 2024 · 2 comments
Open

vernier.prof compare interface doesn't respect tilde #79

zenspider opened this issue Jul 14, 2024 · 2 comments

Comments

@zenspider
Copy link
Contributor

Trying to use the compare feature, files are located at:

https://www.zenspider.com/~ryan/profile.mt.dots.json

and

https://www.zenspider.com/~ryan/profile.mt.quiet.json

which both curl fine from remote, but the compare interface tries to go to:

https://vernier.prof/compare/calltree/?profiles%5B%5D=https%3A%2F%2Fwww.zenspider.com%2F~ryan%2Fprofile.mt.dots.json&profiles%5B%5D=https%3A%2F%2Fwww.zenspider.com%2F~ryan%2Fprofile.mt.quiet.json&v=10

and errors with Error: Unexpected data source ~ryan

@jhawthorn
Copy link
Owner

jhawthorn commented Jul 15, 2024

vernier.prof is 99.9% the same as https://profiler.firefox.com/ (Vernier profiles are compatible with both) so whatever the problem is we'll probably want to fix upstream.

If I use the the regular URL interface instead with one of your URLs I get a more helpful error:

TypeError: NetworkError when attempting to fetch resource.

The full stack has been written to the Web Console.

And then the console reveals:

Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at https://www.zenspider.com/~ryan/profile.mt.quiet.json. (Reason: CORS header ‘Access-Control-Allow-Origin’ missing). Status code: 200.

But I don't get that message from the compare interface so I do think there are two problems: both CORS and URL handling, the latter seemingly specific to the compare tool.

Also full disclosure, I haven't used the compare interface before, so I'm not sure after we get through the network and URL problems how well it works.

@zenspider
Copy link
Contributor Author

zenspider commented Jul 15, 2024

Would my files be compatible (unaltered) with upstream?

ETA: yes, maybe... but irrelevant as everything repros on profiler.firefix.com as well.

Why do they even allow for urls if they can't read set it up to read them? I'm not jumping through hoops to make this work...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants