Make trace_retained API consistent with profile
#69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuay03
force-pushed
the
make-trace-retained-options-consistent
branch
from
90d7616
to
c4c9dd2
Compare
joshuay03
changed the title
trace_retained API consistent with profiletrace_retained API consistent with profile
joshuay03
commented
May 6, 2024
| def self.trace_retained(out: nil, gc: true, &block) | ||
| profile(mode: :retained, out:, gc:, &block) | ||
| def self.trace_retained(**profile_options, &block) | ||
| profile(**profile_options.merge(mode: :retained), &block) |
There was a problem hiding this comment.
We need to ensure the mode isn't overriden.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly a cosmetic change. #61 moved the options to the collector itself, a benefit of that is not having to update all the profile method APIs every time a new option is added.
This ensures
trace_containedis consistent with the rest of these methods.