Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing the ListTextHandler to allow a key to also be 0 #193

Merged
merged 1 commit into from
Jul 5, 2018
Merged

Fixing the ListTextHandler to allow a key to also be 0 #193

merged 1 commit into from
Jul 5, 2018

Conversation

upchuk
Copy link
Contributor

@upchuk upchuk commented Jul 3, 2018 •
edited

Hey there @jhedstrom,

With the current implementation, if the key of the option is 0, the elseif will evaluate to FALSE.

This fix corrects the issue.

@nagyad
Copy link

nagyad commented Jul 4, 2018

Reviewed and tested.

@jhedstrom jhedstrom added the bug label Jul 5, 2018
@jhedstrom jhedstrom merged commit 13addc6 into jhedstrom:master Jul 5, 2018
@jhedstrom
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nagyad nagyad nagyad approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@upchuk @nagyad @jhedstrom