Merge pull request #546 from jhedstrom/545-remove-zombie

Remove Zombie JS from Travis CI

.gitignore

@@ -6,3 +6,4 @@ vendor
 behat.yml
 /package-lock.json
 /node_modules
+/.docksal

.travis.yml

@@ -53,8 +53,6 @@ install:
   - npm install
 
 before_script:
-  # Set NODE_PATH for zombie driver.
-  - export NODE_PATH="`pwd`/node_modules"
   # Define the module path according to the Drupal version being tested.
   - test ${DRUPAL_VERSION} -ne 8 || export MODULE_PATH="drupal/modules"
   - test ${DRUPAL_VERSION} -eq 8 || export MODULE_PATH="drupal/sites/all/modules" && mkdir -p ${MODULE_PATH}
@@ -92,6 +90,7 @@ before_script:
 
 script:
   - composer test
+  - npm test
   - vendor/bin/behat -fprogress --strict
   - vendor/bin/behat -fprogress --profile=drupal${DRUPAL_VERSION} --strict
   # Do not test the Drush profile unless Drupal 7 was installed.

CHANGELOG.md

@@ -9,8 +9,11 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 ### Changed
   * [#528](https://github.com/jhedstrom/drupalextension/pull/528) Show a more helpful failure when running `@javascript`
     scenarios with incorrect configuration.
+  * [#545](https://github.com/jhedstrom/drupalextension/issue/545) Remove Zombie JS testing on Travis.  
 ### Added
   * [#527](https://github.com/jhedstrom/drupalextension/pull/527) Provide a step to check that a button is not in a region.
+  * [#543](https://github.com/jhedstrom/drupalextension/issue/543) Run gherkin-lint against feature files on Travis.
+  * [#544](https://github.com/jhedstrom/drupalextension/issue/544) Added a 'Contributing' section to the README.
 ### Fixed
   * [#542](https://github.com/jhedstrom/drupalextension/pull/542) Fix issue with certain symfony 4 components being pulled in.
 ## [4.0.0 beta2] 2018-12-19

README.md

@@ -98,6 +98,11 @@ the [Full documentation](https://behat-drupal-extension.readthedocs.org)
 
 See [CHANGELOG](CHANGELOG.md).
 
+## Contributing
+
+Features and bug fixes are welcome! First-time contributors can jump in with the
+issues tagged [good first issue](https://github.com/jhedstrom/drupalextension/issues?q=is%3Aissue+is%3Aopen+label%3A%22good+first+issue%22).
+
 ### Backwards incompatible changes
 
 Starting with 3.3.0 Behat Drupal Extension depends on Behat 3.2.0 which

behat.yml.dist

@@ -13,9 +13,7 @@ default:
   extensions:
     Drupal\MinkExtension:
       goutte: ~
-      zombie: ~
       base_url: http://127.0.0.1:8888/blackbox
-      javascript_session: zombie
     Drupal\DrupalExtension:
       blackbox: ~
       region_map:

composer.json

@@ -35,7 +35,6 @@
   },
   "require-dev": {
     "phpspec/phpspec": "~2.0 || ~4.0",
-    "behat/mink-zombie-driver": "^1.2",
     "jakub-onderka/php-parallel-lint": "^0.9.2",
     "drupal/coder": "~8.2.12"
   },

features/blackbox.feature

@@ -85,12 +85,6 @@ Feature: Test DrupalContext
       | Sorry, unrecognized username or password                                      |
       | Unable to send e-mail. Contact the site administrator if the problem persists |
 
-  @javascript
-  Scenario: Zombie driver is functional
-    Given I am on the homepage
-    When I click "Download & Extend"
-    Then I should see the link "Distributions"
-
   @scenariotag
   Scenario: Check tags on feature and scenario
     Then the "scenariotag" tag should be present

features/i18n/es/blackbox.feature

@@ -98,9 +98,3 @@ Característica: Test DrupalContext
        | error messages                                                                |
        | Sorry, unrecognized username or password                                      |
        | Unable to send e-mail. Contact the site administrator if the problem persists |
-
-  @javascript
-  Escenario: El driver Zombie funciona adecuadamente
-    Dado estoy en la página de inicio
-    Cuando hago click en "Download & Extend"
-    Entonces debo ver el enlace "Distributions"

features/messages.feature

@@ -9,11 +9,3 @@ Feature: Ensure that messages are working properly on local installs
     And I fill in "a fake password" for "Password"
     And I press "Log in"
     Then I should see the error message "Unrecognized username or password"
-
-  @javascript
-  Scenario: JS messages
-    Given I am on "/user/login"
-    When I fill in "a fake user" for "Username"
-    And I fill in "a fake password" for "Password"
-    And I press "Log in"
-    Then I should see the error message "Unrecognized username or password"

package.json

@@ -1,7 +1,6 @@
 {
   "devDependencies": {
-    "gherkin-lint": "^2.12.0",
-    "zombie": "^2.5"
+    "gherkin-lint": "^2.12.0"
   },
   "scripts": {
     "gherkin-lint": "gherkin-lint features",