RawDrupalContext::loggedIn() can return false positive #502
Conversation
trwill
changed the title
|
This depends entirely on which theme you are using. The exact selector to use can be configured in |
|
I understand it can be overridden but this is from default theme twig file (which I imagine not too many people need to override) - shouldn't we be setting the default that core ships with? Note that other selectors have been updated to use the new defaults, eg |
|
I can't figure how it's working with the old selector as the form ID doesn't appear to have changed in Drupal 8 since 2013... |
|
@jhedstrom yeah it certainly appears to have been introduced with the launch of Drupal 8. It only 'falls back' to this logic of checking for the form if the |
|
This fix makes sense to me. Thanks! |
The default
login_form_selectoris usingform#user-loginas a selector, but the actual drupal login form (at least for current d8) usesform#user-login-formas the id. My guess is an update to underlying form changed this at some point (maybe during migration to drupal 8?)?This can ultimately cause false positives from
RawDrupalContext::loggedIn()- in some scenarios the login is validated by manually checking the/user/loginpage and looking for the form via this selector - if its not found, the user is assumed to be logged in. In this case even though the user is anonymous, the form is not found, so it returns true.I left the old selector in for any possible BC issues, similar to how the
logged_in_selectorworks.For example, here's a blank site spun up w/ simplytest.me showing the actual selector:
