Start testing on PHP 7.2 #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The test on Drupal 7 is failing because of Issue #2931464: Features PHP 7.2 Function create_function() is deprecated. This has been reported a long time ago but Features for D7 does not see much movement any more. Since this is a bug in the Features module and not in our code we could perhaps opt to apply the patch to Features. |
|
Moving ahead and merging this, it's not changing any functionality and it's making sure we remain compatible with PHP 7.2 so it's better to get this in sooner than later :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP 7.2 has been stable for some time now, let's add it to the test matrix and find out how well we support it!