Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP/RFC: Use Artifacts system #465

Merged
merged 3 commits into from
Sep 16, 2022
Merged

Conversation

sjkelly
Copy link
Contributor

@sjkelly sjkelly commented Jul 29, 2022

This switches GR to use the Artifacts system in its entirety, leading to substantially improved load times.

Before:

julia> @timev using GR
  0.986996 seconds (844.83 k allocations: 49.678 MiB, 1.45% gc time, 88.20% compilation time)
elapsed time (ns): 986996340
gc time (ns):      14332472
bytes allocated:   52091322
pool allocs:       844390
non-pool GC allocs:434
malloc() calls:    6
GC pauses:         1

After:

julia> @timev using GR
  0.243714 seconds (406.49 k allocations: 24.254 MiB, 7.21% compilation time)
elapsed time (ns): 243714086
bytes allocated:   25431816
pool allocs:       406055
non-pool GC allocs:360
malloc() calls:    67
realloc() calls:   7

The substance of the change is quite small, though I suspect some documentation and notes will be required to update workflows (e.g. how to use Overrides.toml rather than environmental variables).

I am throwing this up as an RFC, as this mostly will remove the ability to use environmental variables to select the provider, and rather use Artifacts. As noted, this provides a faster TTFP, but I am unsure if there are concrete reasons (aside from legacy compatability) that environmental variable support should remain.

@mkitti
Copy link
Contributor

mkitti commented Nov 1, 2022

By removing access to alternate binaries, we removed Wayland support.

sciapp/gr#141

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants